From nobody Wed Feb 4 20:47:38 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4f5sqZ5ynbz6QdNw for ; Wed, 04 Feb 2026 20:47:38 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4f5sqZ3c5Kz476s for ; Wed, 04 Feb 2026 20:47:38 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1770238058; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=8Tuv3r4eQo7CLshlIFwdw3UuzZQrvZmwnjV22l0b6a0=; b=IRYTG3H+aV+9ADGOlhPabf5ZYqsC4J77sW8wAPV7NRfaTUe0RCn9UWtXNOmZMV01VOLffc UL97JnBoZ6HjtMiQnnftJOy5lv0mWym6LvmKuJnCDP//TsLucDhMp3NnBXb+h8hTqaWtv9 ZdzgmquCxoyunACnQgiZBoPwg436MeFGwQ8LYMVg3b7h0tttKBm/GvFSm1sf3VT5TM+AVg m3z3qrdBuiqCWBO3DJTpWNXw0ZxFe2+DQraxGtyC9Pcyfuy3Z4nRUw0imEXnWgFlSVMQTK 26nQsBBggStf2L/FYB7MIDtiu/VobM8k/AtNBHvXPMAis0KDRmZCSYET6sCMDA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1770238058; a=rsa-sha256; cv=none; b=dDUAy9optJQ9OtxXcZ/l71Ms9up1FzKOu3tOZe0yw6bjzBZsanCfm+sF4DV/o9fnkhXVVX H5hd/EWN8tyJ3hXi4AT5mtejiH4XQkJ3OLcBHNeBVbAr2lWC+s6SQto5Z1FuYUoz7mX46g OykoZoVKPfBgxFWEHSTxHjxdZSenXHZo3gl+8E5Oq3dFVuJ0lZXZ+WEsV8W1rzqMIIRvHM 03aJXlowBDxeMiMAVBZfNPivLbkQRV4TBTskAG6HJ7BPMBzTUd3xb2FOFi/QG9bXNYhYNj qFI/kmO9NdknFAyLwQEc3pwvGaHwdUpqwTN5Xm3f8SvcHUzrhy3QZ3j6vbJVww== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1770238058; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=8Tuv3r4eQo7CLshlIFwdw3UuzZQrvZmwnjV22l0b6a0=; b=MXJyPgPHuUGAt2aMyFhrcW1NjWvc4T8JB0iiAxr4MxO56EjFgebY5R4OHS3t56F3/FpsSc P2+M517ZypwBfVtdEbw6MWtRppwSLYyM+yzquYcJtKIiQH8qMhGsP/LVd/PI9vFQdLqlW+ w6O07WHyCzi/rq086rOSrmk2ncR0j6G7ZzNX2CJQfTxaXh10ZPZAuhzyW50d8JQg+tK0xd sh9ckgClR8f0t1XjujT9iBufpWFVwNludl20W2FplkCfM68fORMWJn3PGasQUU9poE0BI+ 77QqhITo1SJ0Q3WwALeJfcEFVmCjIZA8iA+imQX94Od5ldSaOSKKux+8zlQ2VQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4f5sqZ2TBgz1DwL for ; Wed, 04 Feb 2026 20:47:38 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3989f by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 04 Feb 2026 20:47:38 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Cy Schubert Subject: git: e40817302ebd - main - ipfilter: Fix possible overrun List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: cy X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: e40817302ebdf89df2f3bcd679fb7f2a18c244dc Auto-Submitted: auto-generated Date: Wed, 04 Feb 2026 20:47:38 +0000 Message-Id: <6983b06a.3989f.673c9651@gitrepo.freebsd.org> The branch main has been updated by cy: URL: https://cgit.FreeBSD.org/src/commit/?id=e40817302ebdf89df2f3bcd679fb7f2a18c244dc commit e40817302ebdf89df2f3bcd679fb7f2a18c244dc Author: Cy Schubert AuthorDate: 2026-02-04 17:27:23 +0000 Commit: Cy Schubert CommitDate: 2026-02-04 20:46:20 +0000 ipfilter: Fix possible overrun The destination buffer is FR_GROUPLEN (16 bytes) in length. When gname is created, the userspace utilities correctly use FR_GROUPLEN as the buffer length. The kernel should also limit its copy operation to FR_GROUPLEN bytes to avoid any user written code from exploiting this vulnerability. Reported by: Ilja Van Sprundel MFC after: 1 week --- sys/netpfil/ipfilter/netinet/fil.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/netpfil/ipfilter/netinet/fil.c b/sys/netpfil/ipfilter/netinet/fil.c index f8b8ffec7bdd..24ac91c69fc8 100644 --- a/sys/netpfil/ipfilter/netinet/fil.c +++ b/sys/netpfil/ipfilter/netinet/fil.c @@ -3503,7 +3503,7 @@ ipf_group_add(ipf_main_softc_t *softc, char *group, void *head, u_32_t flags, fg->fg_head = head; fg->fg_start = NULL; fg->fg_next = *fgp; - bcopy(group, fg->fg_name, strlen(group) + 1); + bcopy(group, fg->fg_name, strnlen(group, FR_GROUPLEN) + 1); fg->fg_flags = gflags; fg->fg_ref = 1; fg->fg_set = &softc->ipf_groups[unit][set];