Date: Sat, 23 Jun 2012 11:24:09 +0200 From: Baptiste Daroussin <bapt@FreeBSD.org> To: Olli Hauer <ohauer@FreeBSD.org> Cc: FreeBSD Ports <ports@FreeBSD.org>, Michael Scheidell <scheidell@FreeBSD.org>, Ganael LAPLANCHE <martymac@FreeBSD.org>, Doug Barton <dougb@FreeBSD.org>, Matthew Seaman <matthew@FreeBSD.org> Subject: Re: optionsng and tinderbox? Message-ID: <20120623092409.GD41054@ithaqua.etoilebsd.net> In-Reply-To: <4FE58855.6000607@FreeBSD.org> References: <4FE1829D.6030109@FreeBSD.org> <20120620091321.GA83730@ithaqua.etoilebsd.net> <20120620094431.M12775@martymac.org> <20120620103412.GB83730@ithaqua.etoilebsd.net> <4FE1C1EA.8070901@FreeBSD.org> <20120621090226.M48537@FreeBSD.org> <4FE4AEFC.4070405@FreeBSD.org> <4FE51858.4010502@FreeBSD.org> <20120623081843.GC41054@ithaqua.etoilebsd.net> <4FE58855.6000607@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--0IvGJv3f9h+YhkrH
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Sat, Jun 23, 2012 at 11:11:49AM +0200, Olli Hauer wrote:
> On 2012-06-23 10:18, Baptiste Daroussin wrote:
> > On Fri, Jun 22, 2012 at 06:14:00PM -0700, Doug Barton wrote:
> >> On 06/22/2012 10:44, Olli Hauer wrote:
> >>> On 2012-06-21 11:26, Ganael LAPLANCHE wrote:
> >>>> On Wed, 20 Jun 2012 13:28:26 +0100, Matthew Seaman wrote
> >>>>
> >>>>> [...]
> >>>>> Shouldn't make.conf / commandline settings override OPTIONSFILE rat=
her
> >>>>> than the other way round? Seems there's not much point in being ab=
le to
> >>>>> set options from make.conf unless that is so, as OPTIONSFILE would =
be
> >>>>> created more often than not whenever make(1) was invoked in the por=
t's
> >>>>> directory.
> >>>>
> >>>> I think that command-line options should always override file ones, =
but
> >>>> the main problem here is that we cannot distinguish what comes from =
the
> >>>> command line from what comes from make.conf.
> >>>>
> >>>> What would sound logical to me would be the following order of prece=
dence :
> >>>>
> >>>> make.conf -> overridden by option files -> overridden by command line
> >>>
> >>>
> >>> This looks wrong to me.
> >>>
> >>> Options set in make.conf should not be overwritten by the option file
> >>> else you don't need etc/make.conf at all.
> >>
> >> Right. make.conf and options files should be flipped in the example ab=
ove.
> >>
> >>
> >> Doug
> >>
> > Well the priority ordering the logical was to give the end word to the =
last user
> > action.
> >=20
> > It goes from global to specific
> >=20
> > 1/ the global options (infrastructures) are applied
> > 2/ the maintainer option (ports are applied)
> > 3/ the user global options are applied (OPTIONS_{,UN}SET)
> > 4/ the user ports options are applied (${UNIQUENAME}_{,UN}SET)
> > 5/ the dialog (make config) options are applied
> >=20
> > If that it looks not good to anyone, please comment (we can still chang=
e it) and
> > please provide arguments.
> >=20
> > regards,
> > Bapt
> >=20
>=20
>=20
> OK, in case of tinderbox or any other build system think about the follow=
ing.
>=20
> You do a build for production or testing and it is required to always use=
pgsql
> and *really* avoid mysql (real use case in my prod builds, I don't care
> about mysql only ports, I just stay away from them).
>=20
> Now you create a fresh build and set the proper build options in build.xx=
x or
> inject a make.conf via post-extract hook since there you want to define w=
ith
> two statements the dependencies.
> - OPTIONS_UNSET+=3DMYSQL
> - OPTIONS_SET+=3DPGSQL
>=20
> This will not work if the directives are overwritten by /4 and /5.
> In case of ports-mgmt/tinderbox you will end with a mysql enabled tinderb=
ox :(
>=20
> To prevent this you have to go over a whole build and all configure dialo=
gs to
> make sure this settings are in place which is not practical, time consumi=
ng
> and error prone.
>=20
> Luckily at the moment /4 and /5 can be overwritten with the old WITH|OUT_=
$opt
> directives since this logic is applied as last in bsd.options.mk
>=20
> So ether fix the logic or keep the old WITH|OUT_$opt logic in bsd.options=
=2Emk
> so we can use make.conf last file of defense.
>=20
> --
> Regards,
> olli
Well when you run from tinderbox or any automated build stuff, you don't run
make config so 5 never occurs.
4/ is made to give a finer grain for specific options for a given ports and=
is
set from make.conf so you can easily tune it for your tinderbox.
regards,
Bapt
--0IvGJv3f9h+YhkrH
Content-Type: application/pgp-signature
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (FreeBSD)
iEYEARECAAYFAk/lizkACgkQ8kTtMUmk6ExPLgCfd2In2V8snSNsSkL0/8w9KvEH
1Q8AnR0PRW2wVuLgXDmWBgoGkq9lIJPv
=FsRq
-----END PGP SIGNATURE-----
--0IvGJv3f9h+YhkrH--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120623092409.GD41054>