From owner-svn-src-head@FreeBSD.ORG  Fri May 24 06:50:35 2013
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by hub.freebsd.org (Postfix) with ESMTP id BD55CAFA;
 Fri, 24 May 2013 06:50:35 +0000 (UTC)
 (envelope-from tuexen@FreeBSD.org)
Received: from mail-n.franken.de (drew.ipv6.franken.de
 [IPv6:2001:638:a02:a001:20e:cff:fe4a:feaa])
 by mx1.freebsd.org (Postfix) with ESMTP id 569FE74;
 Fri, 24 May 2013 06:50:35 +0000 (UTC)
Received: from [192.168.1.200] (p508F0DA0.dip0.t-ipconnect.de [80.143.13.160])
 (Authenticated sender: macmic)
 by mail-n.franken.de (Postfix) with ESMTP id 2FA481C0B2D79;
 Fri, 24 May 2013 08:50:33 +0200 (CEST)
Subject: Re: svn commit: r250809 - head/sys/netinet
Mime-Version: 1.0 (Apple Message framework v1283)
Content-Type: text/plain; charset=us-ascii
From: Michael Tuexen <tuexen@FreeBSD.org>
In-Reply-To: <alpine.BSF.2.00.1305232136460.13079@ai.fobar.qr>
Date: Fri, 24 May 2013 08:50:36 +0200
Content-Transfer-Encoding: quoted-printable
Message-Id: <F8DDC452-016A-409B-87CF-1402DE7EE2E3@FreeBSD.org>
References: <201305191606.r4JG6hNR032154@svn.freebsd.org>
 <alpine.BSF.2.00.1305232136460.13079@ai.fobar.qr>
To: "Bjoern A. Zeeb" <bz@FreeBSD.org>
X-Mailer: Apple Mail (2.1283)
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 src-committers@freebsd.org
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 24 May 2013 06:50:35 -0000

On May 23, 2013, at 11:37 PM, Bjoern A. Zeeb wrote:

> On Sun, 19 May 2013, Michael Tuexen wrote:
>=20
>> Author: tuexen
>> Date: Sun May 19 16:06:43 2013
>> New Revision: 250809
>> URL: http://svnweb.freebsd.org/changeset/base/250809
>>=20
>> Log:
>> Initialize the fibnum for outgoing packets to 0. This avoids
>> crashing due to the usage of uninitialized fibnum.
>> This bugs became visiable after
>> http://svnweb.freebsd.org/changeset/base/250700
>=20
>=20
> That just masks the real bug, please back it out.
And the real bug is that SCTP doesn't support multiple fibs, right?
That would mean the system crashes on reception of an out of the blue
SCTP packet...

Best regards
Michael
>=20
>=20
>> MFC after: 2 weeks
>>=20
>> Modified:
>> head/sys/netinet/sctp_os_bsd.h
>>=20
>> Modified: head/sys/netinet/sctp_os_bsd.h
>> =
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D
>> --- head/sys/netinet/sctp_os_bsd.h	Sun May 19 15:26:15 2013	=
(r250808)
>> +++ head/sys/netinet/sctp_os_bsd.h	Sun May 19 16:06:43 2013	=
(r250809)
>> @@ -435,6 +435,7 @@ typedef struct rtentry sctp_rtentry_t;
>> { \
>> 	int o_flgs =3D IP_RAWOUTPUT; \
>> 	struct sctp_tcb *local_stcb =3D stcb; \
>> +	M_SETFIB(o_pak, 0); \
>> 	if (local_stcb && \
>> 	    local_stcb->sctp_ep && \
>> 	    local_stcb->sctp_ep->sctp_socket) \
>> @@ -445,6 +446,7 @@ typedef struct rtentry sctp_rtentry_t;
>> #define SCTP_IP6_OUTPUT(result, o_pak, ro, ifp, stcb, vrf_id) \
>> { \
>> 	struct sctp_tcb *local_stcb =3D stcb; \
>> +	M_SETFIB(o_pak, 0); \
>> 	if (local_stcb && local_stcb->sctp_ep) \
>> 		result =3D ip6_output(o_pak, \
>> 				    ((struct in6pcb =
*)(local_stcb->sctp_ep))->in6p_outputopts, \
>>=20
>=20
> --=20
> Bjoern A. Zeeb                             ????????? ??? ??????? =
??????:
> '??? ??? ???? ??????  ??????? ?? ?? ??????? ??????? ??? ????? ????? =
????
> ?????? ?? ????? ????',  ????????? ?????????, "??? ????? ?? ?????", =
?.???
>=20