Date: Tue, 3 May 2016 03:02:52 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Cy Schubert <cy@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r414387 - head/x11/xvattr Message-ID: <20160503030252.GD52316@FreeBSD.org> In-Reply-To: <201605010606.u416625F030877@repo.freebsd.org> References: <201605010606.u416625F030877@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, May 01, 2016 at 06:06:02AM +0000, Cy Schubert wrote: > New Revision: 414387 > URL: https://svnweb.freebsd.org/changeset/ports/414387 > > Log: > Make fetchable again. > > Take maintainership of this port. > > Modified: > head/x11/xvattr/Makefile > head/x11/xvattr/distinfo > > Modified: head/x11/xvattr/Makefile > ============================================================================== > --- head/x11/xvattr/Makefile Sun May 1 05:29:08 2016 (r414386) > +++ head/x11/xvattr/Makefile Sun May 1 06:06:02 2016 (r414387) > @@ -5,14 +5,12 @@ PORTNAME= xvattr > PORTVERSION= 1.3 > PORTREVISION= 8 > CATEGORIES= x11 > -MASTER_SITES= ftp://ftp.SpringDaemons.com/soft/ \ > - http://www.dtek.chalmers.se/groups/dvd/dist/ > +MASTER_SITES= http://xvattr.sourcearchive.com/downloads/1.3/ We usually do not hardcode version numbers in MASTER_SITES. While it can be beneficial to be able to copy-paste the URL with a mouse, having to touch MASTER_SITES whenever version changes is considered stronger reason to avoid this. > +DISTFILES= xvattr_1.3.orig.tar.gz Why DISTFILES was used here instead of DISTNAME? Also, it hardcodes the PORTNAME and PORTVERSION which is definitely wrong in this case. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20160503030252.GD52316>