From owner-freebsd-current@FreeBSD.ORG Mon Jul 28 05:20:31 2008 Return-Path: Delivered-To: freebsd-current@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C3F791065674 for ; Mon, 28 Jul 2008 05:20:31 +0000 (UTC) (envelope-from hartzell@alerce.com) Received: from merlin.alerce.com (merlin.alerce.com [64.62.142.94]) by mx1.freebsd.org (Postfix) with ESMTP id AC28D8FC13 for ; Mon, 28 Jul 2008 05:20:31 +0000 (UTC) (envelope-from hartzell@alerce.com) Received: from merlin.alerce.com (localhost [127.0.0.1]) by merlin.alerce.com (Postfix) with ESMTP id 580E433C62; Sun, 27 Jul 2008 21:53:48 -0700 (PDT) Received: from postfix.alerce.com (w092.z064001164.sjc-ca.dsl.cnc.net [64.1.164.92]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by merlin.alerce.com (Postfix) with ESMTP id E800B33C5B; Sun, 27 Jul 2008 21:53:47 -0700 (PDT) Received: by postfix.alerce.com (Postfix, from userid 501) id C1212494FFC; Sun, 27 Jul 2008 21:53:27 -0700 (PDT) From: George Hartzell MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <18573.20679.726675.551186@almost.alerce.com> Date: Sun, 27 Jul 2008 21:53:27 -0700 To: Adam McDougall In-Reply-To: <20080728032427.GN79560@egr.msu.edu> References: <20080727125413.GG1345@garage.freebsd.pl> <20080728032427.GN79560@egr.msu.edu> X-Mailer: VM 7.19 under Emacs 22.1.50.1 X-Virus-Scanned: ClamAV using ClamSMTP X-Mailman-Approved-At: Mon, 28 Jul 2008 11:13:12 +0000 Cc: freebsd-current@FreeBSD.org, Pawel Jakub Dawidek Subject: Re: ZFS patches. X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: hartzell@alerce.com List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Jul 2008 05:20:31 -0000 Adam McDougall writes: > On Sun, Jul 27, 2008 at 02:54:13PM +0200, Pawel Jakub Dawidek wrote: > > Hi. > > http://people.freebsd.org/~pjd/patches/zfs_20080727.patch.bz2 > > The patch applied fine for me, but I get a compile error part way through > a buildworld. My world/kernel is from -current from Thursday, I also > tried csupping HEAD first, cleaning up my source tree, doing things with > headers I shouldn't (which I will revert). To the best of my weak knowledge > of C, it seems like ace_t should be fine (I tried to trace it through the > includes). Am I doing something wrong? Also, is this patch expected to > apply to 7? (I can find out for myself if I don't hear). Thanks. > > cc -O2 -pipe -I/usr/src/cddl/lib/libzpool/../../../sys/cddl/compat/opensolaris > -I/usr/src/cddl/lib/libzpool/../../../cddl/compat/opensolaris/include > -I/usr/src/cddl/lib/libzpool/../../../cddl/compat/opensolaris/lib/libumem > -I/usr/src/cddl/lib/libzpool/../../../cddl/contrib/opensolaris/lib/libzpool/common > -I/usr/src/cddl/lib/libzpool/../../../sys/cddl/contrib/opensolaris/uts/common/sys > -I/usr/src/cddl/lib/libzpool/../../../sys/cddl/contrib/opensolaris/uts/common/fs/zfs > -I/usr/src/cddl/lib/libzpool/../../../sys/cddl/contrib/opensolaris/common/zfs > -I/usr/src/cddl/lib/libzpool/../../../sys/cddl/contrib/opensolaris/uts/common > -I/usr/src/cddl/lib/libzpool/../../../cddl/contrib/opensolaris/head > -I/usr/src/cddl/lib/libzpool/../../../cddl/lib/libumem > -I/usr/src/cddl/lib/libzpool/../../../cddl/contrib/opensolaris/lib/libnvpair -DWANTS_MUTEX_OWNED > -I/usr/src/cddl/lib/libzpool/../../../lib/libpthread/thread > -I/usr/src/cddl/lib/libzpool/../../../lib/libpthread/sys > -I/usr/src/cddl/lib/libzpool/../../../lib/libthr/arch/amd64/include -fstack-protector > -Wno-unknown-pragmas -c > /usr/src/cddl/lib/libzpool/../../../sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_byteswap.c > /usr/src/cddl/lib/libzpool/../../../sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_byteswap.c:35: > error: expected ')' before '*' token > /usr/src/cddl/lib/libzpool/../../../sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_byteswap.c: > In function 'zfs_oldacl_byteswap': > /usr/src/cddl/lib/libzpool/../../../sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_byteswap.c:127: > error: 'ace_t' undeclared (first use in this function) > /usr/src/cddl/lib/libzpool/../../../sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_byteswap.c:127: > error: (Each undeclared identifier is reported only once > /usr/src/cddl/lib/libzpool/../../../sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_byteswap.c:127: > error: for each function it appears in.) > /usr/src/cddl/lib/libzpool/../../../sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_byteswap.c:129: > error: expected expression before ')' token > /usr/src/cddl/lib/libzpool/../../../sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_byteswap.c: > In function 'zfs_znode_byteswap': > /usr/src/cddl/lib/libzpool/../../../sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_byteswap.c:177: > error: 'ace_t' undeclared (first use in this function) > /usr/src/cddl/lib/libzpool/../../../sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_byteswap.c:177: > error: expected expression before ')' token > *** Error code 1 > > Stop in /usr/src/cddl/lib/libzpool. > *** Error code 1 > > Stop in /usr/src/cddl/lib. > *** Error code 1 > > Stop in /usr/src. > *** Error code 1 > > Stop in /usr/src. > *** Error code 1 > > Stop in /usr/src. > *** Error code 1 > > Stop in /usr/src. I see the same thing with a -CURRENT system csup'ed this afternoon. g.