Date: Wed, 5 Oct 2011 20:09:35 GMT From: David Naylor <naylor.b.david@gmail.com> To: freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/160265: [NEW PORT] lang/pypy 1.6 Message-ID: <201110052009.p95K9Zjk058332@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/160265; it has been noted by GNATS.
From: David Naylor <naylor.b.david@gmail.com>
To: lwhsu@freebsd.org
Cc: bug-followup@freebsd.org
Subject: Re: ports/160265: [NEW PORT] lang/pypy 1.6
Date: Wed, 5 Oct 2011 21:00:18 +0200
--Boundary-00=_ElKjOjfwnTlItvt
Content-Type: text/plain;
charset="us-ascii"
Content-Transfer-Encoding: 7bit
On Wednesday, 5 October 2011 20:35:55 you wrote:
> I cannot reproduce this problem in my freebsd8 chroot but I have identified
> a missing '-pthread' in the command. I will investigate.
See attached for my proposed patch. My repository at github
(github.com/DragonSA/pypy) has also been updated with the patch, if the patch
gets eaten by the mail-man.
> Regarding the pkg-plist, would you prefer the static list (as currently
> submitted) or a dynamically created one? This will save 270k.
--Boundary-00=_ElKjOjfwnTlItvt
Content-Type: text/x-python;
charset="iso-8859-1";
name="patch-pypy::translator::platform::freebsd.py"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
filename="patch-pypy::translator::platform::freebsd.py"
--- pypy/translator/platform/freebsd.py 2011-08-15 17:10:35.000000000 +0200
+++ pypy/translator/platform/freebsd.py 2011-10-05 20:49:51.000000000 +0200
@@ -1,6 +1,7 @@
"""Support for FreeBSD."""
import os
+import shlex
from pypy.translator.platform import posix
@@ -10,16 +11,18 @@
else:
return default
-def get_env_vector(key, default):
+def get_env_vector(key, default, required=()):
string = get_env(key, default)
- # XXX: handle quotes
- return string.split()
+ args = shlex.split(string)
+ args.extend(i for i in required if i not in args)
+ return args
class Freebsd(posix.BasePosix):
name = "freebsd"
- link_flags = get_env_vector("LDFLAGS", '-pthread')
- cflags = get_env_vector("CFLAGS", "-O3 -pthread -fomit-frame-pointer")
+ # FreeBSD requires '-pthread' to be passed for successful compiling
+ link_flags = get_env_vector("LDFLAGS", "", ("-pthread",))
+ cflags = get_env_vector("CFLAGS", "-O3 -fomit-frame-pointer", ("-pthread",))
standalone_only = []
shared_only = []
so_ext = 'so'
--Boundary-00=_ElKjOjfwnTlItvt--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201110052009.p95K9Zjk058332>