From owner-svn-src-head@freebsd.org Wed Mar 14 13:20:45 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C5018F5192C for ; Wed, 14 Mar 2018 13:20:45 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-io0-x22c.google.com (mail-io0-x22c.google.com [IPv6:2607:f8b0:4001:c06::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4D8DD805CC for ; Wed, 14 Mar 2018 13:20:44 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-io0-x22c.google.com with SMTP id e7so4369861ioj.1 for ; Wed, 14 Mar 2018 06:20:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=3ZUkfVhp2AjkLbAQ7O0VBGHSB8WCLJKzipKiSfaqzYc=; b=bgVUsoPsbg1sClDs0c3caFrDo8Og0BWTZ7aXoYavSpP1DVXtoP7egTndl0jVxXuGhd nacxQK578yafxwy+jErOKeR08Gr8F90HKYQFvMUhi+yhrUNk+Wuk0uWzgLGxzP+BMqDE np0iVL97QyXQ360ycNLLZkkgFJ6yG5VHsSN3/3peV5wmdrgQjDeI5w73Wgmew3t/e9zn zzU/7m5buooriGks8yXd3hKnCxDn8Wa4OJJXiac8Yh2LRWHdXE5/UUpzuJfzS21r+XGJ 3/GcXFyUqCUpns3lcTDkrKmvDYyiHyaavClZV2p1GC8uN5552YJRO2gk5FTwiE1HpXT0 2q3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=3ZUkfVhp2AjkLbAQ7O0VBGHSB8WCLJKzipKiSfaqzYc=; b=oq6s4GutqWki9/dltkyn4S4ZUZaaTeJZpRO138BE4g/kZMwNRVYtJ6FDFgVWo2kWpH YOogISlg15BBzWOFipxgCKUGMMrP6/z586ndFlHj7Y+NJSZzwJ0KzqJKVQ7k39KCaUU/ bI7c7jW1T2ewLYH5dh5kYuxHL/nLjA6NWVwgNOFlSVG7I9XUMm5ZFy2nxCbK1VL5RRhy RB1wXEKVpEu6aviPHj26YtAMvSgLWemfhMKrjWBfQrG1jOVRu90CnmUIRrHMDwD5SQxc KFj8luzX9fd+hobTeHwCoJ0GBUH1b7zjPrw66im1Zf1/l9Z6wDz8QHNGRSMPJEbCj7PC ZuSg== X-Gm-Message-State: AElRT7GJ1mnxgZn21RXAJvKS58rRMaLp4FdFir3oM52ZEdb0YQQZyN8C 6ddnUmSB+0NkFilvon1xOGgZRRi0xsdIlFt2OTCngA== X-Google-Smtp-Source: AG47ELv1kSK5WUFXVttsrN9tBKgDpVbdkO758pq0ytai8Gs6MvG4iBke3Bc6X3vif9AOOMmz5OTTt9zNQEGJUWviP9c= X-Received: by 10.107.18.162 with SMTP id 34mr4612343ios.168.1521033643671; Wed, 14 Mar 2018 06:20:43 -0700 (PDT) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 10.79.203.196 with HTTP; Wed, 14 Mar 2018 06:20:42 -0700 (PDT) X-Originating-IP: [2603:300b:6:5100:bcea:d775:d975:818] Received: by 10.79.203.196 with HTTP; Wed, 14 Mar 2018 06:20:42 -0700 (PDT) In-Reply-To: <45a6c658-1133-ad46-d8df-48ee5bbccddf@FreeBSD.org> References: <201803132254.w2DMsU2r005593@repo.freebsd.org> <45a6c658-1133-ad46-d8df-48ee5bbccddf@FreeBSD.org> From: Warner Losh Date: Wed, 14 Mar 2018 07:20:42 -0600 X-Google-Sender-Auth: N0emh7PIhhRXKD3eidjgj05fleU Message-ID: Subject: Re: svn commit: r330883 - head/stand/userboot/userboot To: Andriy Gapon Cc: Gleb Smirnoff , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Mar 2018 13:20:46 -0000 On Mar 14, 2018 6:45 AM, "Andriy Gapon" wrote: On 14/03/2018 00:54, Gleb Smirnoff wrote: > Author: glebius > Date: Tue Mar 13 22:54:29 2018 > New Revision: 330883 > URL: https://svnweb.freebsd.org/changeset/base/330883 > > Log: > Fix typo that misteriously passes compilation. > > Modified: > head/stand/userboot/userboot/main.c > > Modified: head/stand/userboot/userboot/main.c > ============================================================ ================== > --- head/stand/userboot/userboot/main.c Tue Mar 13 21:42:38 2018 (r330882) > +++ head/stand/userboot/userboot/main.c Tue Mar 13 22:54:29 2018 (r330883) > @@ -159,7 +159,7 @@ extract_currdev(void) > //bzero(&dev, sizeof(dev)); > > #if defined(USERBOOT_ZFS_SUPPORT) > - CT_ASSERT(sizeof(struct disk_devdesc) >= sizeof(struct zfs_devdesc)); > + CTASSERT(sizeof(struct disk_devdesc) >= sizeof(struct zfs_devdesc)); > if (userboot_zfs_found) { > struct zfs_devdesc zdev; It seems that this was compiled to a call to an external CT_ASSERT function. Probably not enough warning flags to fail on a function without a prototype? Also, not sure how it worked at run-time. Maybe userboot.so is linked and loaded in such a way that it allows undefined symbols as long as they are not used. So, probably extract_currdev() just didn't get called. Anyway, thank you for spotting and fixing. I'll have to see if I can tighten up the warns to prevent this in the future. Warner