From owner-freebsd-arch Tue Oct 24 12:57:51 2000 Delivered-To: freebsd-arch@freebsd.org Received: from palrel1.hp.com (palrel1.hp.com [156.153.255.242]) by hub.freebsd.org (Postfix) with ESMTP id 8E6B637B479 for ; Tue, 24 Oct 2000 12:57:49 -0700 (PDT) Received: from adlmail.cup.hp.com (adlmail.cup.hp.com [15.0.100.30]) by palrel1.hp.com (Postfix) with ESMTP id 70CE8798; Tue, 24 Oct 2000 12:57:48 -0700 (PDT) Received: from cup.hp.com (gauss.cup.hp.com [15.28.97.152]) by adlmail.cup.hp.com (8.9.3 (PHNE_18546)/8.9.3 SMKit7.02) with ESMTP id MAA02324; Tue, 24 Oct 2000 12:57:48 -0700 (PDT) Message-ID: <39F5E9BC.2E7241D9@cup.hp.com> Date: Tue, 24 Oct 2000 15:57:48 -0400 From: Marcel Moolenaar Organization: Hewlett-Packard X-Mailer: Mozilla 4.73 [en] (X11; U; Linux 2.2.12 i386) X-Accept-Language: en MIME-Version: 1.0 To: Warner Losh Cc: arch@freebsd.org Subject: Re: PLEASE REVIEW: buildworld fix for 3.x->RELENG_4 upgrades References: <39F5CDA7.67288AD@cup.hp.com> <39F532B2.BDE29048@cup.hp.com> <39F5185C.62A92866@cup.hp.com> <39F4ADC9.920A9BB5@sftw.com> <39F39B57.8726A8BA@quack.kfu.com> <39F1A95B.86116571@quack.kfu.com> <20001022094114.A14613@dragon.nuxi.com> <200010230405.WAA04356@harmony.village.org> <200010232354.RAA11591@harmony.village.org> <200010240540.XAA13044@harmony.village.org> <200010241254.GAA15044@harmony.village.org> <200010241807.MAA17271@harmony.village.org> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG Warner Losh wrote: > > : So, either we need to install the boot stuff when we install the kernel > : or put the device hints back into GENERIC (and removing the logic as > : illustrated by the patch). > > I see the problem now. It is one of ordering. Yes. > We could easily > install a default device.hints and a corrected boot.conf file as part > of the upgrade process, but we make it needlessly complex due to this > check. This makes it harder to do the upgrade path. Our current upgrade path is not that fully fletched. Yes, ideally you would install the boot loaders before installing a new kernel before install world. It's all planned for the new and improved upgrade target. The problem in ordering is therefore twofold: 1. We need to install the bootloader before we install the kernel, 2. This issue would have been a non-issue if the change was made after we had new upgrade target :-) > I see a couple of ways around this. One is to add a check to see if > you are running 4.x or older and be helpful by doing an implicit copy > of GENERIC.hints to /boot/device.hints as well as doing an install of > the new boot loader in /boot (since really that what the checks you > are proposing removing effectively check for). To be 100% correct, I didn't propose to remove the checks. The patch was to demonstrate what was in the way of doing an upgrade from 4.x to -current. If device hints will not be compiled into the kernel, then we probably need to have these checks, but in a form that doesn't complain to the user, but resolves the problem automaticly as you say. > That is to say these > things would be implied if there was no /boot/device.hint file > pre-existing (we don't want to clobber it) (and that might be a better > check than an OS version, come to think of it). Correct. We can remove the checks in the current form and simply install the hints if not present, this automaticly implies we need to install a new bootloader configuration (does it?) -- Marcel Moolenaar mail: marcel@cup.hp.com / marcel@FreeBSD.org tel: (408) 447-4222 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message