From owner-freebsd-hackers  Fri Aug 27  9:19:35 1999
Delivered-To: freebsd-hackers@freebsd.org
Received: from dt011n65.san.rr.com (dt010nb9.san.rr.com [204.210.12.185])
	by hub.freebsd.org (Postfix) with ESMTP id 5720214E71
	for <freebsd-hackers@FreeBSD.ORG>; Fri, 27 Aug 1999 09:19:30 -0700 (PDT)
	(envelope-from Doug@gorean.org)
Received: from gorean.org (master [10.0.0.2])
	by dt011n65.san.rr.com (8.9.3/8.8.8) with ESMTP id JAA71333
	for <freebsd-hackers@FreeBSD.ORG>; Fri, 27 Aug 1999 09:18:14 -0700 (PDT)
	(envelope-from Doug@gorean.org)
Message-ID: <37C6BA49.28A1140B@gorean.org>
Date: Fri, 27 Aug 1999 09:18:17 -0700
From: Doug <Doug@gorean.org>
Organization: Triborough Bridge & Tunnel Authority
X-Mailer: Mozilla 4.61 [en] (X11; U; FreeBSD 4.0-CURRENT-0826 i386)
X-Accept-Language: en
MIME-Version: 1.0
To: freebsd-hackers@FreeBSD.ORG
Subject: Re: Please review: rc file changes
References: <199908271052.MAA02639@dorifer.heim3.tu-clausthal.de>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: owner-freebsd-hackers@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

Oliver Fromme wrote:
> 
> Doug wrote in list.freebsd-hackers:
>  > [...]
>  > 2. value ) instead of value) for case statements
>  > [...]
>  >      case $? in
>  > -    0)
>  > +            0 )
>  >              ;;
>  > -    2)
>  > +            2 )
>  >              exit 1
>  >              ;;
>  > -    4)
>  > +            4 )
>  >              reboot
>  >              echo "reboot failed... help!"
>  >              exit 1
>  >              ;;
>  > [...]
> 
> Why?!?  I like the existing "case" style _much_ better,
> it's more readable and emphasizes the structure.

	Ok, universal acclaim in both public and private mail is for: 

case $foo in
optinon )

as opposed to:

case $foo in
	option )

so I'll modify that one. It actually improves readability in some cases,
although the latter is a matter of personal style. I would really prefer to
stick with option ) vs. option) though, but if it becomes a show-stopper I
can compromise on that one too. All I ask is that people give it a chance
first. :)

Keep those cards and letters coming,

Doug


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-hackers" in the body of the message