Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 22 Jul 2020 23:39:58 +0000 (UTC)
From:      Brooks Davis <brooks@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r363439 - head/usr.sbin/mountd
Message-ID:  <202007222339.06MNdwBq056707@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: brooks
Date: Wed Jul 22 23:39:58 2020
New Revision: 363439
URL: https://svnweb.freebsd.org/changeset/base/363439

Log:
  Correct a type-mismatch between xdr_long and the variable "bad".
  
  Way back in r28911 (August 1997, CVS rev 1.22) we imported a NetBSD
  information leak fix via OpenBSD.  Unfortunatly we failed to track the
  followup commit that fixed the type of the error code.  Apply the change
  from int to long now.
  
  Reviewed by:	emaste
  Found by:	CHERI
  Obtained from:	CheriBSD
  MFC after:	3 days
  Sponsored by:	DARPA
  Differential Revision:	https://reviews.freebsd.org/D25779

Modified:
  head/usr.sbin/mountd/mountd.c

Modified: head/usr.sbin/mountd/mountd.c
==============================================================================
--- head/usr.sbin/mountd/mountd.c	Wed Jul 22 23:35:41 2020	(r363438)
+++ head/usr.sbin/mountd/mountd.c	Wed Jul 22 23:39:58 2020	(r363439)
@@ -1091,7 +1091,8 @@ mntsrv(struct svc_req *rqstp, SVCXPRT *transp)
 	struct sockaddr *saddr;
 	u_short sport;
 	char rpcpath[MNTPATHLEN + 1], dirpath[MAXPATHLEN];
-	int bad = 0, defset, hostset;
+	int defset, hostset;
+	long bad = 0;
 	sigset_t sighup_mask;
 	int numsecflavors, *secflavorsp;
 



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202007222339.06MNdwBq056707>