From owner-svn-src-head@freebsd.org  Wed May 30 15:45:57 2018
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 87A93F782ED;
 Wed, 30 May 2018 15:45:57 +0000 (UTC) (envelope-from kp@FreeBSD.org)
Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "smtp.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 2B7496A2D7;
 Wed, 30 May 2018 15:45:57 +0000 (UTC) (envelope-from kp@FreeBSD.org)
Received: from venus.codepro.be (venus.codepro.be [IPv6:2a01:4f8:162:1127::2])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
 bits))
 (Client CN "*.codepro.be", Issuer "Gandi Standard SSL CA 2" (verified OK))
 (Authenticated sender: kp)
 by smtp.freebsd.org (Postfix) with ESMTPSA id E4C0B27EEF;
 Wed, 30 May 2018 15:45:56 +0000 (UTC) (envelope-from kp@FreeBSD.org)
Received: from [172.28.128.1]
 (ptr-8ripyygk132m260h1d8.18120a2.ip6.access.telenet.be
 [IPv6:2a02:1811:2419:4e02:8deb:e195:6c41:992c])
 (Authenticated sender: kp)
 by venus.codepro.be (Postfix) with ESMTPSA id C0DE841775;
 Wed, 30 May 2018 17:45:54 +0200 (CEST)
From: "Kristof Provost" <kp@FreeBSD.org>
To: "Conrad Meyer" <cem@freebsd.org>
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 src-committers <src-committers@freebsd.org>
Subject: Re: svn commit: r334375 - in head/sys: net netpfil/pf
Date: Wed, 30 May 2018 17:45:51 +0200
X-Mailer: MailMate (2.0BETAr6111)
Message-ID: <9B1021F6-1746-4198-97BE-42663FE8DFC4@FreeBSD.org>
In-Reply-To: <CAG6CVpWi9ZvPmqNbDMyT+uD4OKiSAeD4zJbDEmk2pf-Fkw+GtQ@mail.gmail.com>
References: <201805300711.w4U7BYjS066960@repo.freebsd.org>
 <20180530141347.1bf868ac@hermann>
 <92B96A88-6F0C-4C5B-A924-4E4CD0777116@FreeBSD.org>
 <20180530143258.64b26810@hermann>
 <D1225E00-9369-4EA6-94B8-8D5CE891B4CD@FreeBSD.org>
 <CAG6CVpWi9ZvPmqNbDMyT+uD4OKiSAeD4zJbDEmk2pf-Fkw+GtQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed; markup=markdown
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.26
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 30 May 2018 15:45:57 -0000

On 30 May 2018, at 17:43, Conrad Meyer wrote:
> On Wed, May 30, 2018 at 5:41 AM, Kristof Provost <kp@freebsd.org> 
> wrote:
>> Odd. The other reports I got were mips only. I did test amd64.
>> Are you using gcc to build perhaps?
>>
>> r334379 should fix it.
>
> Hi Kristof,
>
> Oliver uses a non-GENERIC kernel, which often catches some oversights
> :-).  I appreciate the prompt testing and reports he seems to do
> continuously, it's fantastic.
>
This was very much not criticism of Olivier’s choices ;)
I broke it, so it’s good that someone told me so.

I’m just interested in understanding why he saw the build failure on 
amd64 and I didn’t.

Regards,
Kristof