Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 22 Jun 2022 18:09:15 +0000
From:      Ivan Quitschal <tezeka@hotmail.com>
To:        Hans Petter Selasky <hps@selasky.org>, Tomoaki AOKI <junchoon@dec.sakura.ne.jp>
Cc:        "freebsd-current@freebsd.org" <freebsd-current@freebsd.org>, Kurt Jaeger <pi@freebsd.org>
Subject:   RES: RES: RES: vt newcons mouse paste issue FIXED
Message-ID:  <CP6P284MB1900794465902392ACDA36C2CBB29@CP6P284MB1900.BRAP284.PROD.OUTLOOK.COM>
In-Reply-To: <fd0f9de9-98ac-87b4-2c9d-5fdc27bdb3c4@selasky.org>
References:  <CP6P284MB1900CA1ED5B5BADE054ECB34CBB29@CP6P284MB1900.BRAP284.PROD.OUTLOOK.COM> <f6c1ee1c-bdd9-c8d6-1385-145022e6765d@selasky.org> <CP6P284MB1900CC7B7F6343DAB1D1E5BCCBB29@CP6P284MB1900.BRAP284.PROD.OUTLOOK.COM> <41ef5c38-515f-739a-cb47-7cab0e609526@selasky.org> <CP6P284MB1900DD3D6F41CBAF38CF2CA4CBB29@CP6P284MB1900.BRAP284.PROD.OUTLOOK.COM> <20220623014847.067b18a5ba388639cf6009ce@dec.sakura.ne.jp> <fd0f9de9-98ac-87b4-2c9d-5fdc27bdb3c4@selasky.org>

next in thread | previous in thread | raw e-mail | index | archive | help
Hi=20

This change unfortunately didnt compile on my 13-stable . I just git cloned=
 the CURRENT code, applied the patch and the build was fine.
I'll test it as soon as I finish the upgrade from stable to current here

I'll get back here when its finished=20


Thank you=20


-----Mensagem original-----
De: Hans Petter Selasky <hps@selasky.org>=20
Enviada em: quarta-feira, 22 de junho de 2022 14:08
Para: Tomoaki AOKI <junchoon@dec.sakura.ne.jp>; Ivan Quitschal <tezeka@hotm=
ail.com>
Cc: freebsd-current@freebsd.org; Kurt Jaeger <pi@freebsd.org>
Assunto: Re: RES: RES: vt newcons mouse paste issue FIXED

On 6/22/22 18:48, Tomoaki AOKI wrote:
> Hi.
>=20
> Not actually tested, but this can cause breakage on non-ascii cases.
> Maybe also (or instead) iswspace() test would be needed.
> Possibly additional mbrtowc() in the argument of iswspace().
>=20
> Please see `man 3 multibyte` and `man 3 iswspace`.
> (Possibly more to see.)
>=20
> Characters in buf can be multibyte or wide char depending on locale,=20
> as vt can show at least UTF-8 characters.
>=20
> Sorry, not looked into enough how UTF-8 characters outside ascii are=20
> handled internally on vt.
>=20

Thanks for your feedback.

Now using the TCHAR_CHARACTER() macro, which is already used for space sepa=
ration.

See:
https://nam12.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Freviews=
.freebsd.org%2FD35552&amp;data=3D05%7C01%7C%7C179337d1a7a340b8a9eb08da5471c=
67e%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637915144907733421%7CUnkno=
wn%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVC=
I6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=3Db4hKmkmuXxZ%2BjtSv75bG8qLIXMwo9Fzt64Nf=
VSnuDUU%3D&amp;reserved=3D0

--HPS




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CP6P284MB1900794465902392ACDA36C2CBB29>