From owner-freebsd-current@FreeBSD.ORG Fri Nov 18 22:22:45 2005 Return-Path: X-Original-To: freebsd-current@freebsd.org Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6803516A41F for ; Fri, 18 Nov 2005 22:22:45 +0000 (GMT) (envelope-from rhurlin@gwdg.de) Received: from mailer.gwdg.de (mailer.gwdg.de [134.76.10.26]) by mx1.FreeBSD.org (Postfix) with ESMTP id C246E43D46 for ; Fri, 18 Nov 2005 22:22:44 +0000 (GMT) (envelope-from rhurlin@gwdg.de) Received: from p213.54.65.172.tisdip.tiscali.de ([213.54.65.172] helo=[192.168.1.111]) by mailer.gwdg.de with esmtpsa (TLSv1:RC4-MD5:128) (Exim 4.54) id 1EdEcw-00066N-GL; Fri, 18 Nov 2005 23:22:42 +0100 Message-ID: <437E542C.5070602@gwdg.de> Date: Fri, 18 Nov 2005 23:22:36 +0100 From: Rainer Hurling User-Agent: Mozilla Thunderbird 1.0.7 (X11/20051106) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Craig Rodrigues References: <437E1477.7030902@gwdg.de> <20051118190448.GA6870@crodrigues.org> In-Reply-To: <20051118190448.GA6870@crodrigues.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Level: +++ X-Spam-Report: Content analysis: 3.3 points, 6.0 required 1.5 RCVD_IN_MAPS_RBL RBL: Relay in RBL, http://www.mail-abuse.org/rbl+/ [213.54.65.172 listed in rbl-plus.mail-abuse.org] 0.1 RCVD_IN_SORBS_DUL RBL: SORBS: sent directly from dynamic IP address [213.54.65.172 listed in dnsbl.sorbs.net] 1.7 RCVD_IN_NJABL_DUL RBL: NJABL: dialup sender did non-local SMTP [213.54.65.172 listed in combined.njabl.org] X-Virus-Scanned: (clean) by exiscan+sophie X-AUTH-Id: rhurlin Cc: freebsd-current@freebsd.org Subject: Re: mount_msdosfs and longnames X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Nov 2005 22:22:45 -0000 Craig, thank you for your reply. I tried your patch and build my system again. Now I am able to mount_msdosfs with option 'longnames', as described in manpage. I get no error message anymore. Unfortunately this did not solve my main problem. As before, the FAT32 partitions are shown only with 8.3 naming convention in small letters. Obviously I am not able to change it by mount options. Do you have any other idea? Are there related changes in the files 'msdosfs_fileno.c' and 'msdosfs_denode.c', both from 10/31/2005? Rainer Craig Rodrigues wrote: > On Fri, Nov 18, 2005 at 06:50:47PM +0100, Rainer Hurling wrote: > >>Looking in /usr/src/sys/fs/msdosfs/msdosfs_vfsops.c [Version 1.147 from >>2005/10/31 15:41:20] there is a naming discrepancy against the manpage: >>supported options are 'shortname' and 'longname' without s. I hope I did >>not misunderstood this. > > > There was a naming discrepancy between the userland mount_msdosfs > utility, and the implementation of the option in the > msdos_vfsops.c for quite a while which was hidden in the mess > of the old mount code. When I converted mount_msdosfs to use nmount(), > this discrepancy was uncovered. > > Can you try this patch? > > Index: msdosfs_vfsops.c > =================================================================== > RCS file: /home/ncvs/src/sys/fs/msdosfs/msdosfs_vfsops.c,v > retrieving revision 1.147 > diff -u -u -r1.147 msdosfs_vfsops.c > --- msdosfs_vfsops.c 31 Oct 2005 15:41:20 -0000 1.147 > +++ msdosfs_vfsops.c 18 Nov 2005 19:02:40 -0000 > @@ -81,7 +81,7 @@ > "from", > "export", > "uid", "gid", "mask", "dirmask", > - "shortname", "longname", "win95", > + "shortname", "shortnames", "longname", "longnames", "win95", > "kiconv", "cs_win", "cs_dos", "cs_local", > NULL > }; > @@ -163,8 +163,12 @@ > pmp->pm_dirmask = v & ALLPERMS; > vfs_flagopt(mp->mnt_optnew, "shortname", > &pmp->pm_flags, MSDOSFSMNT_SHORTNAME); > + vfs_flagopt(mp->mnt_optnew, "shortnames", > + &pmp->pm_flags, MSDOSFSMNT_SHORTNAME); > vfs_flagopt(mp->mnt_optnew, "longname", > &pmp->pm_flags, MSDOSFSMNT_LONGNAME); > + vfs_flagopt(mp->mnt_optnew, "longnames", > + &pmp->pm_flags, MSDOSFSMNT_LONGNAME); > vfs_flagopt(mp->mnt_optnew, "kiconv", > &pmp->pm_flags, MSDOSFSMNT_KICONV);