From owner-cvs-all Thu Jul 19 7:48:33 2001 Delivered-To: cvs-all@freebsd.org Received: from bazooka.unixfreak.org (bazooka.unixfreak.org [63.198.170.138]) by hub.freebsd.org (Postfix) with ESMTP id B5C5937B405; Thu, 19 Jul 2001 07:48:28 -0700 (PDT) (envelope-from dima@unixfreak.org) Received: from hornet.unixfreak.org (hornet [63.198.170.140]) by bazooka.unixfreak.org (Postfix) with ESMTP id B5C133E2F; Thu, 19 Jul 2001 07:48:22 -0700 (PDT) To: Sheldon Hearn Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.sbin/newsyslog newsyslog.8 In-Reply-To: <20721.995553422@axl.seasidesoftware.co.za>; from sheldonh@starjuice.net on "Thu, 19 Jul 2001 16:37:02 +0200" Date: Thu, 19 Jul 2001 07:48:22 -0700 From: Dima Dorfman Message-Id: <20010719144822.B5C133E2F@bazooka.unixfreak.org> Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Sheldon Hearn writes: > > > On Thu, 19 Jul 2001 04:18:43 MST, Dima Dorfman wrote: > > > Although they sound the same, since both of them rotate logs at the > > beginning of the day, the former ended up taking place on, e.g., July > > 31 00:00 instead of the expected July 31 23:59. This is contraty to POLA > . > > July 31 23:59 isn't good, it's just "not as bad as" July 31 00:00. Both > allow for logs from last month to end up in this month's files. > > This example should be shot. Even if it isn't replaced with an example > of "rotate at the first day of every month at midnight", it should still > be shot. Did you actually look at the diff, or are you just complaining about the commit log? Now that I read it again the latter wasn't all that great, but the actual change is fine, IMO. > > Ciao, > Sheldon. > To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message