From owner-svn-src-head@freebsd.org  Sun Oct  8 15:42:46 2017
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0896AE38BDB;
 Sun,  8 Oct 2017 15:42:46 +0000 (UTC)
 (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net)
Received: from pdx.rh.CN85.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id A10F264A46;
 Sun,  8 Oct 2017 15:42:45 +0000 (UTC)
 (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net)
Received: from pdx.rh.CN85.dnsmgr.net (localhost [127.0.0.1])
 by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3) with ESMTP id v98FgZ1c074040;
 Sun, 8 Oct 2017 08:42:35 -0700 (PDT)
 (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net)
Received: (from freebsd@localhost)
 by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3/Submit) id v98FgZ5f074039;
 Sun, 8 Oct 2017 08:42:35 -0700 (PDT) (envelope-from freebsd)
From: "Rodney W. Grimes" <freebsd@pdx.rh.CN85.dnsmgr.net>
Message-Id: <201710081542.v98FgZ5f074039@pdx.rh.CN85.dnsmgr.net>
Subject: Re: svn commit: r324406 - head/sys/modules/em
In-Reply-To: <95D45458-24C3-473C-80AF-A2C622747886@gmail.com>
To: Ngie Cooper <yaneurabeya@gmail.com>
Date: Sun, 8 Oct 2017 08:42:35 -0700 (PDT)
CC: Sean Bruno <sbruno@freebsd.org>, src-committers@freebsd.org,
 svn-src-all@freebsd.org, svn-src-head@freebsd.org
Reply-To: rgrimes@freebsd.org
X-Mailer: ELM [version 2.4ME+ PL121h (25)]
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=US-ASCII
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 08 Oct 2017 15:42:46 -0000

> 
> > On Oct 7, 2017, at 16:33, Sean Bruno <sbruno@FreeBSD.org> wrote:
> > 
> > Author: sbruno
> > Date: Sat Oct  7 23:33:14 2017
> > New Revision: 324406
> > URL: https://svnweb.freebsd.org/changeset/base/324406
> > 
> > Log:
> >  Fix symlink if_igb.ko in -current such that its relative and doesn't
> >  end up with non-standard DESTDIR information in its symlink.  This
> >  can happen very trivially if the release scripts are used.
> > 
> >  Sponsored by:    Limelight Networks
> > 
> > Modified:
> >  head/sys/modules/em/Makefile
> > 
> > Modified: head/sys/modules/em/Makefile
> > ==============================================================================
> > --- head/sys/modules/em/Makefile    Sat Oct  7 23:30:57 2017    (r324405)
> > +++ head/sys/modules/em/Makefile    Sat Oct  7 23:33:14 2017    (r324406)
> > @@ -23,6 +23,6 @@ CFLAGS += -I${SRCTOP}/sys/dev/e1000
> > #CFLAGS  += -DDEVICE_POLLING
> > 
> > afterinstall:
> > -    ln -sf ${DESTDIR}${KMODDIR}/${KMOD}.ko ${DESTDIR}${KMODDIR}/if_igb.ko
> > +    cd ${DESTDIR}${KMODDIR} && ln -sf if_em.ko if_igb.ko
> 
> While this is definitely better, the same thing could be achieved via:
> 
> ln -sf if_em.ko ${DESTDIR}/.../if_igb.ko

Should this be using SYMLINK+= as I thought using ln -sf was a breakage
for meta mode stuff?

-- 
Rod Grimes                                                 rgrimes@freebsd.org