From owner-freebsd-usb@FreeBSD.ORG Tue Nov 9 01:50:42 2004 Return-Path: Delivered-To: freebsd-usb@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F1B2B16A4CE for ; Tue, 9 Nov 2004 01:50:42 +0000 (GMT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id DEB3443D48 for ; Tue, 9 Nov 2004 01:50:42 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.11/8.12.11) with ESMTP id iA91odFi019930 for ; Tue, 9 Nov 2004 01:50:39 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.11/8.12.11/Submit) id iA91ocs5019929; Tue, 9 Nov 2004 01:50:39 GMT (envelope-from gnats) Date: Tue, 9 Nov 2004 01:50:39 GMT Message-Id: <200411090150.iA91ocs5019929@freefall.freebsd.org> To: freebsd-usb@FreeBSD.org From: Ian Dowse Subject: Re: kern/70607: [patch] Add Support for USB Microsoft Intellimouse (possibly others) X-BeenThere: freebsd-usb@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Ian Dowse List-Id: FreeBSD support for USB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Nov 2004 01:50:43 -0000 The following reply was made to PR kern/70607; it has been noted by GNATS. From: Ian Dowse To: Anish Mistry , Matt Wright Cc: freebsd-gnats-submit@freebsd.org Subject: Re: kern/70607: [patch] Add Support for USB Microsoft Intellimouse (possibly others) Date: Tue, 09 Nov 2004 01:41:26 +0000 In message <200411082140.iA8LeXQs087630@freefall.freebsd.org>, Anish Mistry wri > Excellent work Matt. I've just tested it with my wired Intellimouse, and > it works great on my laptop (6-CURRENT). It didn't work on my desktop, > but I think the USB controller is flaky, ums just gets 1 interrupt then > gets stuck, but my other USB mice still worked fine, so no regressions. ... > Could a committer (Ian?) take a look at this a possibly merge it? Sure, but one question about the patch: is it necessary to add the new field to the mousestatus structure, i.e. is there any userland code that needs the new `dt' field from the MOUSE_GETSTATUS ioctl? If not, it would be better to avoid having to recompile any existing applications that may use the MOUSE_GETSTATUS ioctl. Adding the new field would also require modifying all the other mouse drivers (sysmouse, mse, psm, pc98/mse) to initialise `dt'. Ian