From owner-freebsd-current  Sun Mar 16 21:28:33 2003
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 9CA8A37B404; Sun, 16 Mar 2003 21:28:31 -0800 (PST)
Received: from ebb.errno.com (ebb.errno.com [66.127.85.87])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 9DC2C43F85; Sun, 16 Mar 2003 21:28:30 -0800 (PST)
	(envelope-from sam@errno.com)
Received: from melange (melange.errno.com [66.127.85.82])
	(authenticated bits=0)
	by ebb.errno.com (8.12.8/8.12.6) with ESMTP id h2H5SMmm009376
	(version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NO);
	Sun, 16 Mar 2003 21:28:30 -0800 (PST)
	(envelope-from sam@errno.com)
Message-ID: <33c601c2ec46$0d48dce0$52557f42@errno.com>
From: "Sam Leffler" <sam@errno.com>
To: "Alfred Perlstein" <bright@mu.org>, <sam@freebsd.org>
Cc: <imp@freebsd.org>, <current@freebsd.org>
References: <20030317051920.GN4145@elvis.mu.org> <20030317052534.GO4145@elvis.mu.org>
Subject: Re: wi driver
Date: Sun, 16 Mar 2003 21:28:25 -0800
Organization: Errno Consulting
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
X-Priority: 3
X-MSMail-Priority: Normal
X-Mailer: Microsoft Outlook Express 5.50.4807.1700
X-MimeOLE: Produced By Microsoft MimeOLE V5.50.4807.1700
Sender: owner-freebsd-current@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-current.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-current>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-current>
X-Loop: FreeBSD.ORG

> * Alfred Perlstein <bright@mu.org> [030316 21:19] wrote:
> > um..
> >
> ...
> 840     _FLAGS_OUTRANGE) {
> 841                     WI_UNLOCK(sc);
> 842                     return;
> 843             }
> 844             KASSERT((ifp->if_flags & IFF_OACTIVE) == 0,
> 845                     ("wi_start: if_flags %x\n", ifp->if_flags));
> 846
> 847             memset(&frmhdr, 0, sizeof(frmhdr));
>
> >
> > What's up here?
>
> It's a race, we shouldn't be inspecting the ifp without a lock.
>
> I think this kassert should be removed.
>
> Do you guys concurr?

Warner has this pending with some other fixes; perhaps he can accelerate
doing the commit?  The assert is actually just bogus (if_start can be called
under certain conditions with IFF_OACTIVE set.

    Sam


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message