From owner-svn-src-all@FreeBSD.ORG Thu Dec 13 16:12:50 2012 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 604A73BD; Thu, 13 Dec 2012 16:12:50 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) by mx1.freebsd.org (Postfix) with ESMTP id B7E998FC08; Thu, 13 Dec 2012 16:12:49 +0000 (UTC) Received: from tom.home (kostik@localhost [127.0.0.1]) by kib.kiev.ua (8.14.5/8.14.5) with ESMTP id qBDGChaQ042136; Thu, 13 Dec 2012 18:12:43 +0200 (EET) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.7.1 kib.kiev.ua qBDGChaQ042136 Received: (from kostik@localhost) by tom.home (8.14.5/8.14.5/Submit) id qBDGChB2042135; Thu, 13 Dec 2012 18:12:43 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Thu, 13 Dec 2012 18:12:42 +0200 From: Konstantin Belousov To: Pawel Jakub Dawidek Subject: Re: svn commit: r244154 - head/bin/ps Message-ID: <20121213161242.GE71906@kib.kiev.ua> References: <201212121545.qBCFj4Hl086444@svn.freebsd.org> <20121212210652.GO3013@kib.kiev.ua> <20121213111240.GB1381@garage.freebsd.pl> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="zjcmjzIkjQU2rmur" Content-Disposition: inline In-Reply-To: <20121213111240.GB1381@garage.freebsd.pl> User-Agent: Mutt/1.5.21 (2010-09-15) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on tom.home Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, jhb@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Dec 2012 16:12:50 -0000 --zjcmjzIkjQU2rmur Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Dec 13, 2012 at 12:12:44PM +0100, Pawel Jakub Dawidek wrote: > On Wed, Dec 12, 2012 at 11:06:52PM +0200, Konstantin Belousov wrote: > > On Wed, Dec 12, 2012 at 03:45:04PM +0000, Pawel Jakub Dawidek wrote: > > > Author: pjd > > > Date: Wed Dec 12 15:45:03 2012 > > > New Revision: 244154 > > > URL: http://svnweb.freebsd.org/changeset/base/244154 > > >=20 > > > Log: > > > Use kern.max_pid sysctl to obtain maximum PID number instead of usi= ng local > > > define. > > It is pid_max, not max_pid. > >=20 > > But the change is wrong. The kern.pid_max only limits newly allocated p= ids, > > it does not magically moves existing pids, which are out of range, to t= he > > limited region. See the corresponding commit log for the description. > > It was added to make it easier to run FreeBSD 1.x binaries on the modern > > kernels. >=20 > I saw CTLFLAG_TUN on the sysctl and assumed it is read-only... > How about defining BSD_PID_MAX in sys/proc.h, which would be visible by > userland as well and setting PID_MAX to BSD_PID_MAX? >=20 > This would also help bsnmpd. >=20 > http://people.freebsd.org/~pjd/patches/PID_MAX.patch Do you know why PID_MAX is under _KERNEL ? If there is no real reason, it would be better to move it outside kernel-only section. sys/proc.h is not in POSIX anyway. --zjcmjzIkjQU2rmur Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iEYEARECAAYFAlDJ/noACgkQC3+MBN1Mb4j2ZgCeO92KcVRMVW2xcqobnFmWXwcN q2IAoM1XvZJdiTEAm9JwjQWk3epumwre =gZLA -----END PGP SIGNATURE----- --zjcmjzIkjQU2rmur--