From owner-cvs-all@FreeBSD.ORG  Sat Mar 27 02:34:46 2010
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@FreeBSD.org
Received: by hub.freebsd.org (Postfix, from userid 1033)
	id D8A6D1065670; Sat, 27 Mar 2010 02:34:46 +0000 (UTC)
Date: Sat, 27 Mar 2010 02:34:46 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Stanislav Sedov <stas@FreeBSD.org>
Message-ID: <20100327023446.GA52463@FreeBSD.org>
References: <201003211256.o2LCur0a025048@repoman.freebsd.org>
	<20100326191544.d17a11df.stas@FreeBSD.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=koi8-r
Content-Disposition: inline
In-Reply-To: <20100326191544.d17a11df.stas@FreeBSD.org>
User-Agent: Mutt/1.4.2.1i
Cc: beyert@cs.ucr.edu, cvs-ports@FreeBSD.org, ports-committers@FreeBSD.org,
	cvs-all@FreeBSD.org, Martin Wilke <miwi@FreeBSD.org>
Subject: Re: cvs commit: ports/textproc Makefile ports/textproc/htmlc
	Makefile distinfo pkg-descr
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: **OBSOLETE** CVS commit messages for the entire tree
	<cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 27 Mar 2010 02:34:46 -0000

Just a couple of more comments, now that stas@ gave a diff; hope you
don't mind Martin.

On Fri, Mar 26, 2010 at 07:15:44PM -0700, Stanislav Sedov wrote:
> On Sun, 21 Mar 2010 12:56:53 +0000 (UTC)
> Martin Wilke <miwi@FreeBSD.org> mentioned:
> +MAINTAINER=    beyert@cs.ucr.edu
> +COMMENT=       A text file generator

I'm afraid COMMENT should be augmented here; it is way too generic to
describe a port.

> +#MAN1=         htmlc.1

Any reason for this commented out statement?

> +HAS_CONFIGURE= yes
> +CONFIGURE_ARGS=        --prefix ${LOCALBASE}
> 
> This looks weird.  Is this port PREFIX safe?

In fact, passing correct --prefix is one thing of GNU_ vs. HAS_
CONFIGURE statements.  Does this port uses autotools-generated configure
script, by chance?  If yes, you should have dropped bogus --prefix
assignment (entire CONFIGURE_ARGS line) and just use GNU_CONFIGURE.  If
configure script is not autotools-generated, but accepts --prefix, it
should probably be ${PREFIX}.  If this particular port assumes PREFIX ==
LOCALBASE, comment should be provided stating (at best, explaining) it.

> +do-install:
> +       @${INSTALL_PROGRAM} ${WRKSRC}/compiler/htmlc ${PREFIX}/bin
> +       @${INSTALL_PROGRAM} ${WRKSRC}/compiler/htmlc.byt ${PREFIX}/bin
> +       @${MKDIR} ${DATADIR}
> +       @${INSTALL_DATA} ${WRKSRC}/config/env ${DATADIR}

INSTALL_FOO statements should not be muted.

./danfe