From owner-svn-src-head@FreeBSD.ORG  Wed Jul 31 05:03:19 2013
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTP id 7FA50131;
 Wed, 31 Jul 2013 05:03:19 +0000 (UTC) (envelope-from bright@mu.org)
Received: from elvis.mu.org (elvis.mu.org [192.203.228.196])
 by mx1.freebsd.org (Postfix) with ESMTP id 28F2F29D4;
 Wed, 31 Jul 2013 05:03:19 +0000 (UTC)
Received: from kruse-124.4.ixsystems.com (drawbridge.ixsystems.com
 [206.40.55.65])
 by elvis.mu.org (Postfix) with ESMTPSA id E51BD1A3C2C;
 Tue, 30 Jul 2013 22:03:12 -0700 (PDT)
Message-ID: <51F89A91.1070806@mu.org>
Date: Tue, 30 Jul 2013 22:03:13 -0700
From: Alfred Perlstein <bright@mu.org>
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7;
 rv:17.0) Gecko/20130620 Thunderbird/17.0.7
MIME-Version: 1.0
To: =?ISO-8859-1?Q?Ulrich_Sp=F6rlein?= <uqs@FreeBSD.org>, 
 Alfred Perlstein <alfred@FreeBSD.org>,
 src-committers@freebsd.org, svn-src-all@freebsd.org, 
 svn-src-head@freebsd.org
Subject: Re: svn commit: r253719 - in head: sys/conf sys/dev/watchdog
 sys/libkern sys/sys usr.sbin/watchdogd
References: <201307272047.r6RKl2vI023259@svn.freebsd.org>
 <20130730112447.GA54133@acme.spoerlein.net>
In-Reply-To: <20130730112447.GA54133@acme.spoerlein.net>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 31 Jul 2013 05:03:19 -0000

On 7/30/13 4:24 AM, Ulrich Spörlein wrote:
> On Sat, 2013-07-27 at 20:47:02 +0000, Alfred Perlstein wrote:
>> Author: alfred
>> Date: Sat Jul 27 20:47:01 2013
>> New Revision: 253719
>> URL: http://svnweb.freebsd.org/changeset/base/253719
>>
>> Log:
>>    Fix watchdog pretimeout.
> Alfred,
>
> this broken the build and hasn't been fixed for almost three days now.
> What's up with that? How was this change tested before commit?
>
> ===> usr.sbin/watchdogd (all)
> cc  -O2 -pipe  -std=gnu99 -Qunused-arguments -fstack-protector -Wsystem-headers -Werror -Wall -Wno-format-y2k -W -Wno-unused-parameter -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch -Wshadow -Wunused-parameter -Wcast-align -Wchar-subscripts -Winline -Wnested-externs -Wredundant-decls -Wold-style-definition -Wmissing-variable-declarations -Wno-pointer-sign -Wno-empty-body -Wno-string-plus-int -c /data/src/freebsd-head/usr.sbin/watchdogd/watchdogd.c
> /data/src/freebsd-head/usr.sbin/watchdogd/watchdogd.c:777:18: error: comparison of integers of different signs: 'u_int' (aka 'unsigned int') and 'time_t' (aka 'int') [-Werror,-Wsign-compare]
>                  if (pretimeout >= ts.tv_sec) {
>                      ~~~~~~~~~~ ^  ~~~~~~~~~
> 1 error generated.
> *** Error code 1
>
Yikes!  What?

I did test this a ton of times.  My apologies to all.

Let me see what I can do.

-Alfred