From owner-freebsd-stable@FreeBSD.ORG Sat Jan 1 00:17:10 2011 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DC04E106566B for ; Sat, 1 Jan 2011 00:17:10 +0000 (UTC) (envelope-from swhetzel@gmail.com) Received: from mail-bw0-f54.google.com (mail-bw0-f54.google.com [209.85.214.54]) by mx1.freebsd.org (Postfix) with ESMTP id 6A3678FC14 for ; Sat, 1 Jan 2011 00:17:10 +0000 (UTC) Received: by bwz12 with SMTP id 12so5303924bwz.13 for ; Fri, 31 Dec 2010 16:17:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:in-reply-to :references:date:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=sbeBloCf3k4w3fY0ET3sei6YUt8QM9NmYu1hAyOzOto=; b=ljONn7M4G6BlszgNAsYzL6GlCioaF7BtrmCU3iW0He/8ybRH3Es/4FC4ErOTGGFJR3 Q9cr9DMEBcrIXJvCGh+4YNvviOh/M8td57T443iyjEcKRDEoaldG1otCbmtOqzMOxaEs UzXbXfquroE4bvTm9jwwPB8tkvT2ih8TPXEIg= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=V25+/A9Vcr2z8j8iyiQYTJFF7irk8uXGsRDkhFjJNi6fw+YHOKE7olv9ByfKBhMEOD keGV1neuLYVq6ygo1Zsp1Xfe9d5Qz9JN24zp7Jv49hXVChWKE42DA4zvwiVqO4ABVZFR jjXFnzDBLt/TsysVWEW0I7IJgvyNaOeKd1QDE= MIME-Version: 1.0 Received: by 10.204.140.70 with SMTP id h6mr8140109bku.117.1293839663235; Fri, 31 Dec 2010 15:54:23 -0800 (PST) Received: by 10.204.73.76 with HTTP; Fri, 31 Dec 2010 15:54:23 -0800 (PST) In-Reply-To: References: Date: Fri, 31 Dec 2010 17:54:23 -0600 Message-ID: From: Scot Hetzel To: Chris Forgeron Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: "freebsd-stable@freebsd.org" Subject: Re: ZFS v28 and zil_disable X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 01 Jan 2011 00:17:10 -0000 On Fri, Dec 31, 2010 at 4:00 PM, Chris Forgeron wrote: > BTW, I'm noticing the removal of vfs.zfs.zil_disable as well - It's not l= isted as a sysctl when I check vfs.zfs, but I see it's still in the source = code; > > In usr/src/sys/cddl/ : > # grep -r zil_disable * > cddl/contrib/opensolaris/uts/common/fs/zfs/sys/zil.h.orig:extern int zil_= disable; > cddl/contrib/opensolaris/uts/common/fs/zfs/zil.c.orig:int zil_disable =3D= 0; =A0 =A0 =A0/* disable intent logging */ > cddl/contrib/opensolaris/uts/common/fs/zfs/zil.c.orig:TUNABLE_INT("vfs.zf= s.zil_disable", &zil_disable); > cddl/contrib/opensolaris/uts/common/fs/zfs/zil.c.orig:SYSCTL_INT(_vfs_zfs= , OID_AUTO, zil_disable, CTLFLAG_RW, &zil_disable, 0, > cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_vfsops.c.orig: =A0 if (zil= _disable) { > cddl/contrib/opensolaris/uts/common/fs/zfs/zvol.c.orig: =A0 =A0 =A0 =A0 i= f (bp->bio_cmd =3D=3D BIO_FLUSH && !zil_disable) > > All the files above show that the original files (*.orig) have the zil_disa= ble. Your grep of the sources shows that zil_disable was removed from zil.h, zil.c, zfs_vfsops.c and zvol.c. I looked at pjd's perforce repository and found that zil_disable was renamed to zil_replay_disable. Scot