From owner-cvs-all@FreeBSD.ORG  Tue Oct 16 19:58:41 2007
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id C7B8816A46B;
	Tue, 16 Oct 2007 19:58:41 +0000 (UTC)
	(envelope-from scottl@samsco.org)
Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57])
	by mx1.freebsd.org (Postfix) with ESMTP id 7D32513C494;
	Tue, 16 Oct 2007 19:58:41 +0000 (UTC)
	(envelope-from scottl@samsco.org)
Received: from phobos.samsco.home (phobos.samsco.home [192.168.254.11])
	(authenticated bits=0)
	by pooker.samsco.org (8.13.8/8.13.8) with ESMTP id l9GJwZYI075111;
	Tue, 16 Oct 2007 13:58:35 -0600 (MDT)
	(envelope-from scottl@samsco.org)
Message-ID: <471517C8.9040505@samsco.org>
Date: Tue, 16 Oct 2007 13:58:00 -0600
From: Scott Long <scottl@samsco.org>
User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US;
	rv:1.8.1.6) Gecko/20070802 SeaMonkey/1.1.4
MIME-Version: 1.0
To: Roman Divacky <rdivacky@FreeBSD.org>
References: <200710122211.l9CMBM4J010733@repoman.freebsd.org>
	<20071016085414.GA27376@freebsd.org>
In-Reply-To: <20071016085414.GA27376@freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by
	milter-greylist-2.0.2 (pooker.samsco.org [168.103.85.57]);
	Tue, 16 Oct 2007 13:58:35 -0600 (MDT)
X-Spam-Status: No, score=-1.4 required=5.5 tests=ALL_TRUSTED autolearn=failed
	version=3.1.8
X-Spam-Checker-Version: SpamAssassin 3.1.8 (2007-02-13) on pooker.samsco.org
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/cam/scsi scsi_all.h
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 16 Oct 2007 19:58:41 -0000

Roman Divacky wrote:
> On Fri, Oct 12, 2007 at 10:11:22PM +0000, Scott Long wrote:
>> scottl      2007-10-12 22:11:22 UTC
>>
>>   FreeBSD src repository
>>
>>   Modified files:
>>     sys/cam/scsi         scsi_all.h 
>>   Log:
>>   Add a bunch of definitions and structures to support newer drivers.
> 
> -       page_start = (void *)((u_int8_t *)&mode_header[1] +
> +       page_start = (void *)((u_int8_t *)&mode_header[2] +
>                                scsi_2btoul(mode_header->blk_desc_len));
> 
> are you sure this belongs here? 
> 

It's a minor bug fix that got grouped with the larger change.  Are you
upset that it wasn't clearly documented in the commit message, or are 
you pointing out that it's incorrect, or what?

Scott