From owner-cvs-all@FreeBSD.ORG Sun Jun 4 14:44:21 2006 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CCDDA16A4DF; Sun, 4 Jun 2006 14:44:21 +0000 (UTC) (envelope-from iedowse@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id AC53A43D69; Sun, 4 Jun 2006 14:44:18 +0000 (GMT) (envelope-from iedowse@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k54Egc8E099111; Sun, 4 Jun 2006 14:42:38 GMT (envelope-from iedowse@repoman.freebsd.org) Received: (from iedowse@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k54Egc2k099110; Sun, 4 Jun 2006 14:42:38 GMT (envelope-from iedowse) Message-Id: <200606041442.k54Egc2k099110@repoman.freebsd.org> From: Ian Dowse Date: Sun, 4 Jun 2006 14:42:38 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/usb if_axe.c if_axereg.h X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 04 Jun 2006 14:44:21 -0000 iedowse 2006-06-04 14:42:38 UTC FreeBSD src repository Modified files: sys/dev/usb if_axe.c if_axereg.h Log: Add a sleep lock that protects access to sequences of blocking axe_cmd() calls. Without this the device can get confused if multiple threads attempt these operations concurrently. The problem was easily reproducible by running "ifconfig axe0" in a loop because eventually it would conflict with axe_tick_task(). A similar approach is probably required in all USB ethernet drivers. Revision Changes Path 1.38 +39 -3 src/sys/dev/usb/if_axe.c 1.10 +4 -0 src/sys/dev/usb/if_axereg.h