Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 1 Apr 2016 09:49:28 +0300
From:      Andriy Gapon <avg@FreeBSD.org>
To:        Mateusz Guzik <mjg@FreeBSD.org>, src-committers@FreeBSD.org, svn-src-all@FreeBSD.org, svn-src-head@FreeBSD.org
Subject:   Re: svn commit: r297481 - head/sys/kern
Message-ID:  <56FE19F8.10905@FreeBSD.org>
In-Reply-To: <20160401061250.GA24248@dft-labs.eu>
References:  <20160401061250.GA24248@dft-labs.eu>

next in thread | previous in thread | raw e-mail | index | archive | help
On 01/04/2016 09:12, Mateusz Guzik wrote:
> Author: mjg
> Date: Wed Apr  1 08:10:00 2016
> New Revision: 280963
> URL: https://svnweb.freebsd.org/changeset/base/297481
> 
> Log:
>   Increase responsiveness under load by being more aggressive with
>   priority changes.
> 
>   MFC after:	1 week
> 
> Modified:
>   head/sys/kern/sched_ule.c
> 
> Modified: head/sys/kern/sched_ule.c
> ===================================================================
> --- sys/kern/sched_ule.c	(revision 297480)
> +++ sys/kern/sched_ule.c	(working copy)
> @@ -1696,15 +1696,10 @@
>  	} 
>  	ts = td->td_sched;
>  	THREAD_LOCK_ASSERT(td, MA_OWNED);
> -	if (td->td_priority == prio)
> -		return;
>  	/*
> -	 * If the priority has been elevated due to priority
> -	 * propagation, we may have to move ourselves to a new
> -	 * queue.  This could be optimized to not re-add in some
> -	 * cases.
> +	 * DOES THIS WORK LOL

It does!  Nice one!

>  	 */
> -	if (TD_ON_RUNQ(td) && prio < td->td_priority) {
> +	if (TD_ON_RUNQ(td) && prio != td->td_priority) {
>  		sched_rem(td);
>  		td->td_priority = prio;
>  		sched_add(td, SRQ_BORROWING);
> 


-- 
Andriy Gapon



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?56FE19F8.10905>