From owner-svn-src-all@FreeBSD.ORG  Tue Dec 31 12:11:48 2013
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id D8CCB5EF;
 Tue, 31 Dec 2013 12:11:48 +0000 (UTC)
Received: from svn.freebsd.org (svn.freebsd.org
 [IPv6:2001:1900:2254:2068::e6a:0])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id C522A1CCF;
 Tue, 31 Dec 2013 12:11:48 +0000 (UTC)
Received: from svn.freebsd.org ([127.0.1.70])
 by svn.freebsd.org (8.14.7/8.14.7) with ESMTP id rBVCBmjZ076420;
 Tue, 31 Dec 2013 12:11:48 GMT
 (envelope-from melifaro@svn.freebsd.org)
Received: (from melifaro@localhost)
 by svn.freebsd.org (8.14.7/8.14.7/Submit) id rBVCBmrm076419;
 Tue, 31 Dec 2013 12:11:48 GMT
 (envelope-from melifaro@svn.freebsd.org)
Message-Id: <201312311211.rBVCBmrm076419@svn.freebsd.org>
From: "Alexander V. Chernikov" <melifaro@FreeBSD.org>
Date: Tue, 31 Dec 2013 12:11:48 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: svn commit: r260124 - head/usr.bin/netstat
X-SVN-Group: head
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 31 Dec 2013 12:11:48 -0000

Author: melifaro
Date: Tue Dec 31 12:11:48 2013
New Revision: 260124
URL: http://svnweb.freebsd.org/changeset/base/260124

Log:
  Explicitly free rt_tables to please Coverity.
  
  Reported by:	Coverity
  Coverity CID:	1147174
  MFC after:	2 weeks

Modified:
  head/usr.bin/netstat/route.c

Modified: head/usr.bin/netstat/route.c
==============================================================================
--- head/usr.bin/netstat/route.c	Tue Dec 31 11:54:37 2013	(r260123)
+++ head/usr.bin/netstat/route.c	Tue Dec 31 12:11:48 2013	(r260124)
@@ -426,7 +426,7 @@ p_rtable_kvm(int fibnum, int af)
 
 	if (kread((u_long)(rtree), (char *)(rt_tables) + fibnum * af_size,
 	    af_size) != 0)
-		return;
+		err(EX_OSERR, "error retrieving radix pointers");
 	for (fam = 0; fam <= AF_MAX; fam++) {
 		int tmpfib;
 
@@ -462,6 +462,8 @@ p_rtable_kvm(int fibnum, int af)
 			p_rtree_kvm(head.rnh_treetop);
 		}
 	}
+
+	free(rt_tables);
 }
 
 /*