From owner-svn-src-head@freebsd.org Thu Aug 9 16:02:11 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3773C106B2D4; Thu, 9 Aug 2018 16:02:11 +0000 (UTC) (envelope-from bu7cher@yandex.ru) Received: from forward106j.mail.yandex.net (forward106j.mail.yandex.net [IPv6:2a02:6b8:0:801:2::109]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "forwards.mail.yandex.net", Issuer "Yandex CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id A573B7B513; Thu, 9 Aug 2018 16:02:10 +0000 (UTC) (envelope-from bu7cher@yandex.ru) Received: from mxback16j.mail.yandex.net (mxback16j.mail.yandex.net [IPv6:2a02:6b8:0:1619::92]) by forward106j.mail.yandex.net (Yandex) with ESMTP id 9166718061B2; Thu, 9 Aug 2018 19:01:59 +0300 (MSK) Received: from smtp4p.mail.yandex.net (smtp4p.mail.yandex.net [2a02:6b8:0:1402::15:6]) by mxback16j.mail.yandex.net (nwsmtp/Yandex) with ESMTP id VkhMn87jVX-1xIWRdlW; Thu, 09 Aug 2018 19:01:59 +0300 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1533830519; bh=RTG9QSyaX+jlKqKYVoVsxvSi6UvtFJ3Wquv8NfpZCos=; h=Subject:To:Cc:References:From:Message-ID:Date:In-Reply-To; b=CtOucxA0ViYSIqQja11DgQWAwlfdUiGVwwCOCjFZtZlvmWDv8qGh3LIEWCKMfOsmB AgMPcjR1eyeeHWfjk4uYRorqfGccgvTq7nkSsnfQ1abgt5hOtpn2bMZqw7GHe9w3JO XjPeOs4OD8feLSkFgXOmNmQO58zOYvp1eIUXCl+o= Received: by smtp4p.mail.yandex.net (nwsmtp/Yandex) with ESMTPSA id 2KJkKTHhdN-1wqqGl6I; Thu, 09 Aug 2018 19:01:59 +0300 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client certificate not present) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1533830519; bh=RTG9QSyaX+jlKqKYVoVsxvSi6UvtFJ3Wquv8NfpZCos=; h=Subject:To:Cc:References:From:Message-ID:Date:In-Reply-To; b=CtOucxA0ViYSIqQja11DgQWAwlfdUiGVwwCOCjFZtZlvmWDv8qGh3LIEWCKMfOsmB AgMPcjR1eyeeHWfjk4uYRorqfGccgvTq7nkSsnfQ1abgt5hOtpn2bMZqw7GHe9w3JO XjPeOs4OD8feLSkFgXOmNmQO58zOYvp1eIUXCl+o= Authentication-Results: smtp4p.mail.yandex.net; dkim=pass header.i=@yandex.ru Subject: Re: svn commit: r337536 - head/sbin/ipfw To: rgrimes@freebsd.org Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201808091548.w79Fm8Ed018168@pdx.rh.CN85.dnsmgr.net> From: "Andrey V. Elsukov" Openpgp: id=E6591E1B41DA1516F0C9BC0001C5EA0410C8A17A Autocrypt: addr=bu7cher@yandex.ru; prefer-encrypt=mutual; keydata= xsBNBEwBF1kBCADB9sXFhBEUy8qQ4X63Y8eBatYMHGEFWN9ypS5lI3RE6qQW2EYbxNk7qUC5 21YIIS1mMFVBEfvR7J9uc7yaYgFCEb6Sce1RSO4ULN2mRKGHP3/Sl0ijZEjWHV91hY1YTHEF ZW/0GYinDf56sYpDDehaBF5wkWIo1+QK5nmj3vl0DIDCMNd7QEiWpyLVwECgLX2eOAXByT8B bCqVhJGcG6iFP7/B9Ll6uX5gb8thM9LM+ibwErDBVDGiOgvfxqidab7fdkh893IBCXa82H9N CNwnEtcgzh+BSKK5BgvPohFMgRwjti37TSxwLu63QejRGbZWSz3OK3jMOoF63tCgn7FvABEB AAHNIkFuZHJleSBWLiBFbHN1a292IDxhZUBmcmVlYnNkLm9yZz7CwHsEEwECACUCGwMGCwkI BwMCBhUIAgkKCwQWAgMBAh4BAheABQJMB/ruAhkBAAoJEAHF6gQQyKF6MLwH/3Ri/TZl9uo0 SepYWXOnxL6EaDVXDA+dLb1eLKC4PRBBjX29ttQ0KaWapiE6y5/AfzOPmRtHLrHYHjd/aiHX GMLHcYRXD+5GvdkK8iMALrZ28X0JXyuuZa8rAxWIWmCbYHNSBy2unqWgTI04Erodk90IALgM 9JeHN9sFqTM6zalrMnTzlcmel4kcjT3lyYw3vOKgoYLtsLhKZSbJoVVVlvRlGBpHFJI5AoYJ SyfXoN0rcX6k9X7Isp2K50YjqxV4v78xluh1puhwZyC0p8IShPrmrp9Oy9JkMX90o6UAXdGU KfdExJuGJfUZOFBTtNIMNIAKfMTjhpRhxONIr0emxxDOwE0ETAEXWQEIAJ2p6l9LBoqdH/0J PEFDY2t2gTvAuzz+8zs3R03dFuHcNbOwjvWCG0aOmVpAzkRa8egn5JB4sZaFUtKPYJEQ1Iu+ LUBwgvtXf4vWpzC67zs2dDuiW4LamH5p6xkTD61aHR7mCB3bg2TUjrDWn2Jt44cvoYxj3dz4 S49U1rc9ZPgD5axCNv45j72tggWlZvpefThP7xT1OlNTUqye2gAwQravXpZkl5JG4eOqJVIU X316iE3qso0iXRUtO7OseBf0PiVmk+wCahdreHOeOxK5jMhYkPKVn7z1sZiB7W2H2TojbmcK HZC22sz7Z/H36Lhg1+/RCnGzdEcjGc8oFHXHCxUAEQEAAcLAXwQYAQIACQUCTAEXWQIbDAAK CRABxeoEEMihegkYCAC3ivGYNe2taNm/4Nx5GPdzuaAJGKWksV+w9mo7dQvU+NmI2az5w8vw 98OmX7G0OV9snxMW+6cyNqBrVFTu33VVNzz9pnqNCHxGvj5dL5ltP160JV2zw2bUwJBYsgYQ WfyJJIM7l3gv5ZS3DGqaGIm9gOK1ANxfrR5PgPzvI9VxDhlr2juEVMZYAqPLEJe+SSxbwLoz BcFCNdDAyXcaAzXsx/E02YWm1hIWNRxanAe7Vlg7OL+gvLpdtrYCMg28PNqKNyrQ87LQ49O9 50IIZDOtNFeR0FGucjcLPdS9PiEqCoH7/waJxWp6ydJ+g4OYRBYNM0EmMgy1N85JJrV1mi5i Message-ID: Date: Thu, 9 Aug 2018 19:01:35 +0300 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <201808091548.w79Fm8Ed018168@pdx.rh.CN85.dnsmgr.net> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="N69pLIyczzLTbSCZeYfQq2Uz5E9zmW55O" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Aug 2018 16:02:11 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --N69pLIyczzLTbSCZeYfQq2Uz5E9zmW55O Content-Type: multipart/mixed; boundary="UJWIzXMrMDONHFGFBhkb5em8cEPA5Dl6b"; protected-headers="v1" From: "Andrey V. Elsukov" To: rgrimes@freebsd.org Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-ID: Subject: Re: svn commit: r337536 - head/sbin/ipfw References: <201808091548.w79Fm8Ed018168@pdx.rh.CN85.dnsmgr.net> In-Reply-To: <201808091548.w79Fm8Ed018168@pdx.rh.CN85.dnsmgr.net> --UJWIzXMrMDONHFGFBhkb5em8cEPA5Dl6b Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 09.08.2018 18:48, Rodney W. Grimes wrote: >>> This now means -q has 2 functions, silence most commands, >>> and silently ignore errors on delete. >>> >>> That is a poor implementation of syntax and options. >> >> I think it makes "delete" command to have the same behavior as describ= ed >> for commands in "-q" description: >=20 > Which is yet another bug in your commit, you did not update the > synopsis or the description of the -q flag to include your > change. Though oddly the synopsis does show delete -q, it > how ever does not show -q for any of the table commands. >=20 >> >> -q Be quiet when executing the add, nat, zero, resetlog or flush >> commands; (implies -f). > No mention of what it does on delete, does -q on delete imply -f? >=20 >> This is useful when updating rulesets by >> executing multiple ipfw commands in a script (e.g., >> ?sh?/etc/rc.firewall?), or by processing a file with many ipfw >> rules across a remote login session. It also stops a table add >> or delete from failing if the entry already exists or is not >> present. >=20 > That suggesting that -q is good for remote login session is > poor advice at best, you should redirect both standard and > error output to a file, depending on -q is just a loaded > gun waiting to go off. >=20 >> >> table add/delete commands had the same behavior, "nat" already noted i= n >> this list. What is the usage scenario do you use, where you need to fa= il >> on bad delete? >=20 > if [ ipfw delete ${1} ]; then > handle the missing rule > fi This is mostly unneeded operation, that we wanted to avoid. I.e. to be able run in bath mode: delete ${n} add ${n} ... > But more importantly you seem to be ignoring the aspect that > your overloading a "silent" option with a "ignore failure" > option. That is bad design. The description of the -q flag > is already 2x as long as it should be in a good design. I have a feeling you are watching each my commit and comment it :) I did not designed this behavior, at work we use another tool to work with rules and tables. I'm fine with reverting this change. Do you want to restore previous behavior? AFAIR, julian@ complains that ipfw(8) has some error states that should be removed. --=20 WBR, Andrey V. Elsukov --UJWIzXMrMDONHFGFBhkb5em8cEPA5Dl6b-- --N69pLIyczzLTbSCZeYfQq2Uz5E9zmW55O Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Comment: Using GnuPG with Thunderbird - https://www.enigmail.net/ iQEzBAEBCAAdFiEE5lkeG0HaFRbwybwAAcXqBBDIoXoFAltsZV8ACgkQAcXqBBDI oXrR+wf+LF3YioMLJfoFxsxnopo1/8AG5QMiKtSAHO+zj/t0Kj0gKcIrFWtYcoNL QVqjYXTqGVmipGFFqK0julCyynvlKRw2LalbkFGxxbVGF4iH7sv1dt+IDTuVABB5 nbvj0CzrV86RMz7tTOxbheLlsK85oNSU6TDngztpKnApYRRO4ROi3BqkMZDxQ0xg bquRWp/cTAu6w+t0EY0nRiK7gW6iG9HpvYnGbS7MxMcccXNDarsCLfqaPKNC0Ycq AXLZsYOAFRaBLBlTpAVcETQghwMyrWk3oPhQ8aYL3edKNxOkExzb3N/tJZBoO0t+ 1oHLLcK0IMUyagw0mTNtyShwZ5EMqA== =JjSe -----END PGP SIGNATURE----- --N69pLIyczzLTbSCZeYfQq2Uz5E9zmW55O--