From owner-freebsd-current@freebsd.org Tue Dec 15 08:40:33 2020 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 8F9184AE0C7 for ; Tue, 15 Dec 2020 08:40:33 +0000 (UTC) (envelope-from freebsd@grem.de) Received: from mail.evolve.de (mail.evolve.de [213.239.217.29]) (using TLSv1.3 with cipher TLS_CHACHA20_POLY1305_SHA256 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA512 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mail.evolve.de", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4CwBXw3Dtzz3LCX; Tue, 15 Dec 2020 08:40:32 +0000 (UTC) (envelope-from freebsd@grem.de) Received: by mail.evolve.de (OpenSMTPD) with ESMTP id 88cd3f85; Tue, 15 Dec 2020 08:40:22 +0000 (UTC) Received: by mail.evolve.de (OpenSMTPD) with ESMTPSA id b92ef507 (TLSv1.3:AEAD-CHACHA20-POLY1305-SHA256:256:NO); Tue, 15 Dec 2020 08:40:18 +0000 (UTC) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (1.0) Subject: Re: after update to r368166: no sound recording From: Michael Gmelin In-Reply-To: Date: Tue, 15 Dec 2020 09:40:16 +0100 Cc: freebsd-current@freebsd.org, kaktus@freebsd.org, sbruno@freebsd.org, Hans Petter Selasky Message-Id: References: To: Matthias Apitz X-Mailer: iPhone Mail (18B92) X-Rspamd-Queue-Id: 4CwBXw3Dtzz3LCX X-Spamd-Bar: --- X-Spamd-Result: default: False [-3.00 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; R_DKIM_ALLOW(-0.20)[grem.de:s=20180501]; MID_RHS_MATCH_FROM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; MV_CASE(0.50)[]; R_SPF_ALLOW(-0.20)[+ip4:213.239.217.29/32]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[grem.de]; NEURAL_HAM_LONG(-1.00)[-1.000]; RCPT_COUNT_FIVE(0.00)[5]; SPAMHAUS_ZRD(0.00)[213.239.217.29:from:127.0.2.255]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[grem.de:+]; NEURAL_HAM_SHORT(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RBL_DBL_DONT_QUERY_IPS(0.00)[213.239.217.29:from]; ASN(0.00)[asn:24940, ipnet:213.239.192.0/18, country:DE]; RCVD_TLS_ALL(0.00)[]; MAILMAN_DEST(0.00)[freebsd-current] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Dec 2020 08:40:33 -0000 > On 15. Dec 2020, at 08:44, Matthias Apitz wrote: >=20 > =EF=BB=BFEl d=C3=ADa lunes, diciembre 14, 2020 a las 10:16:21a. m. +0100, M= atthias Apitz escribi=C3=B3: >=20 >> I did a step by step down grading with 'svn up -r..... hdaa.c hdaa.h' >> (only these two files), starting from r368166 down to the following revis= ions: >>=20 >> r368166: no recording from pcm1 >>=20 >> r358333: no recording from pcm1 >>=20 >> r350078: no recording from pcm1 >>=20 >> r337043: recording is fine >>=20 >> I've cc'ed now the commiters of the r358333 and r350078. kaktus@ and sbru= no@ >> please check the issue https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D= 251727 >> and this mail thread in current@ >=20 > I have nailed down the problem and locally fixed it with this: >=20 > # svn diff sys/dev/sound/pci/hda/hdaa.c > Index: sys/dev/sound/pci/hda/hdaa.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- sys/dev/sound/pci/hda/hdaa.c (revisi=C3=B3n: 368166) > +++ sys/dev/sound/pci/hda/hdaa.c (copia de trabajo) > @@ -6598,6 +6598,7 @@ > devinfo->newgpo =3D -1; > callout_init(&devinfo->poll_jack, 1); > devinfo->poll_ival =3D hz; > + devinfo->init_clear =3D 1; /* added by guru@unixarea.de */ >=20 > hdaa_lock(devinfo); > res =3D hda_command(dev, >=20 > because there seems to be no code to set devinfo->init_clear from > loader.conf; there is in hdaa.c: >=20 > SYSCTL_ADD_INT(device_get_sysctl_ctx(dev), > SYSCTL_CHILDREN(device_get_sysctl_tree(dev)), OID_AUTO, > "init_clear", CTLFLAG_RW, > &devinfo->init_clear, 1,"Clear initial pin widget configuration= "); >=20 > but I don't see any function like hdaa_init_clear_handler() which writes > the value to devinfo->init_clear;=20 >=20 > Am I mistaken? >=20 > matthias >=20 >=20 Good catch, I played with the sysctl as well as device.hints, both which did= n=E2=80=99t (seem to) make a difference. -m > --=20 > Matthias Apitz, =E2=9C=89 guru@unixarea.de, http://www.unixarea.de/ +49-17= 6-38902045 > Public GnuPG key: http://www.unixarea.de/key.pub