From owner-freebsd-arch@FreeBSD.ORG Tue Nov 13 22:59:09 2012 Return-Path: Delivered-To: arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 35142D14 for ; Tue, 13 Nov 2012 22:59:09 +0000 (UTC) (envelope-from bapt@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id 0BB828FC13; Tue, 13 Nov 2012 22:59:09 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id qADMx8Zo046191; Tue, 13 Nov 2012 22:59:08 GMT (envelope-from bapt@freebsd.org) Received: (from bapt@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id qADMx8gC046190; Tue, 13 Nov 2012 22:59:08 GMT (envelope-from bapt@freebsd.org) X-Authentication-Warning: freefall.freebsd.org: bapt set sender to bapt@freebsd.org using -f Date: Tue, 13 Nov 2012 23:59:05 +0100 From: Baptiste Daroussin To: Konstantin Belousov Subject: Re: Increasing MAXLOGNAME from 17 to 33 Message-ID: <20121113225905.GB75103@ithaqua.etoilebsd.net> References: <20121113111806.GE62533@ithaqua.etoilebsd.net> <20121113115034.GJ73505@kib.kiev.ua> <20121113183412.GA75103@ithaqua.etoilebsd.net> <20121113184238.GO73505@kib.kiev.ua> <20121113184512.GP73505@kib.kiev.ua> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="oLBj+sq0vYjzfsbl" Content-Disposition: inline In-Reply-To: <20121113184512.GP73505@kib.kiev.ua> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: arch@freebsd.org X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Nov 2012 22:59:09 -0000 --oLBj+sq0vYjzfsbl Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Nov 13, 2012 at 08:45:12PM +0200, Konstantin Belousov wrote: > On Tue, Nov 13, 2012 at 08:42:38PM +0200, Konstantin Belousov wrote: > > On Tue, Nov 13, 2012 at 07:34:12PM +0100, Baptiste Daroussin wrote: > > > On Tue, Nov 13, 2012 at 01:50:34PM +0200, Konstantin Belousov wrote: > > > > On Tue, Nov 13, 2012 at 12:18:06PM +0100, Baptiste Daroussin wrote: > > > > > Hi, > > > > >=20 > > > > > I want to increase MAXLOGNAME in sys/param.h from 17 to 33 to all= ow 32-character > > > > > long usernames, the PR: misc/161091 and misc/133926 already reque= sted for it. > > > > >=20 > > > > > utmpx already allow 32 character long user names. > > > > >=20 > > > > > I plan to bump the __FreeBSD_version at the same time because of = the ABI > > > > > breakage. > > > > >=20 > > > > > This is simplify life of lots administrator, this value, is a com= mon value for > > > > > other operating systems. > > > > >=20 > > > > > Do anyone have objections about it? > > > >=20 > > > > Yes, I have. Do not break the ABI, it is plain prohibited. > > > > You might consider increasing the constant only if providing ABI > > > > compatibility shims. > > > >=20 > > > > In fact, the cursory look over the whole base system indicates that= ABI > > > > breakage might be not that big and could be mitigated with relative= ly > > > > limited amount of the efforts. > > >=20 > > > Thanks cognet for the help on the following. > > >=20 > > > After auditing base, it seems like this patch is enough > > > http://people.freebsd.org/~bapt/maxlogname-33.diff > > Regarding the patch, the dereferencing of p->p_session should be done > > under the proc lock to guarantee stability of p_pgrp, and under session > > mutex to prevent s_login modifications. Altogether, this means that the > > if() shall be moved down right before bcopy and locks unlocked on retur= n. > >=20 > Sorry, sent the reply too early. >=20 > The alternative is to check for the length of the local 'login' variable > after unlocks, right before copyout. >=20 like this? http://people.freebsd.org/~bapt/report-erange-if-login-is-larger-then-MAXLO= GNAME.diff regards, Bapt --oLBj+sq0vYjzfsbl Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iEYEARECAAYFAlCi0LkACgkQ8kTtMUmk6EyRvwCfVWXqMEZStUMu5yDXDEyDDf1E vjEAn1f49XyyQ18vXqmp5pzSI8ILaLY9 =Sksf -----END PGP SIGNATURE----- --oLBj+sq0vYjzfsbl--