Date: Sat, 23 Mar 2024 16:54:13 +0100 From: Moin Rahman <bofh@freebsd.org> To: ports-committers <ports-committers@freebsd.org> Cc: Sunpoet Po-Chuan Hsieh <sunpoet@freebsd.org>, Gleb Popov <arrowd@freebsd.org>, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 28472e9722d8 - main - Revert "x11-fonts/noto*: Restructure and update" Message-ID: <2B7512A8-09EC-4A3B-B594-529E9354215E@freebsd.org> In-Reply-To: <2567403.0dHE6SNnxz@angua.firefly> References: <202403231404.42NE4baU095633@gitrepo.freebsd.org> <CALH631=Q0Hc%2BYnvREbe0aNR%2BVeWaNv3YdekKmeUe_Kf6tXD6TQ@mail.gmail.com> <2567403.0dHE6SNnxz@angua.firefly>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_561E7F91-CF57-44BE-B8F3-FC704AEDD3A9 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Mar 23, 2024, at 4:38 PM, Tobias C. Berner <tcberner@gmail.com> = wrote: >=20 > Am Samstag, 23. M=C3=A4rz 2024, 15:14:01 CET schrieb Gleb Popov: >> On Sat, Mar 23, 2024 at 5:04=E2=80=AFPM Po-Chuan Hsieh = <sunpoet@freebsd.org> wrote: >>> The branch main has been updated by sunpoet: >>>=20 >>> URL: >>> = https://cgit.FreeBSD.org/ports/commit/?id=3D28472e9722d808739a4d690f6d803a= 2 >>> b1b8f5f98 >>>=20 >>> commit 28472e9722d808739a4d690f6d803a2b1b8f5f98 >>> Author: Po-Chuan Hsieh <sunpoet@FreeBSD.org> >>> AuthorDate: 2024-03-23 14:01:07 +0000 >>> Commit: Po-Chuan Hsieh <sunpoet@FreeBSD.org> >>> CommitDate: 2024-03-23 14:01:07 +0000 >>>=20 >>> Revert "x11-fonts/noto*: Restructure and update" >>>=20 >>> This reverts commit 3b128ff9f74b28ada2f475f0b816480b1550e5b8. >>=20 >> It is good manners to explain the reason for reverting when doing it. >> Even better to first talk to the original committer and ask him to = the >> revert. >=20 > Moin moin >=20 > I completely agree. Given that there has been a phabricator review = open for > two months, with you, sunpoet@ as reviewer, this is looking like poor > judgement on your side. >=20 > As arrowd@ points out, you should have commented on the reverted = commit first, > and elaborate your reasoning for a revert. >=20 > Simply reverting the work of others may lead to fewer contributions. = Please > take this into consideration in the future. >=20 >=20 > mfg Tobias To be frank there are two problems here: 1. Being less communicative. However I do not blame sunpoet@ at all for = this. And we the entire community is responsible for this. Jumping into = communication is really tiring and draining of mental health and also = counter-productive. 2. However the major problem I see here is actually the workflow. =46rom = the later commits I am more than sure that he had some local works which = really did not go well with the reverted commit and was difficult to rebase. So = rather than fixing the rebase conflict the commit was reverted so the rest of = the commits can be rebased and pushed. In multiple occasions it has been = mentioned to have more atomic pushes rather than this amount of commits in one go. With my fingers crossed I hope this commit will return with a different patch from sunpoet himself. Kind regards, Moin --Apple-Mail=_561E7F91-CF57-44BE-B8F3-FC704AEDD3A9 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEETfdREoUGjQZKBS+fvbm1phfAvJEFAmX++yVfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDRE Rjc1MTEyODUwNjhEMDY0QTA1MkY5RkJEQjlCNUE2MTdDMEJDOTEACgkQvbm1phfA vJFl3g/9GBpvku2/oUo9qGLRdm1HrpoXYigbB6HmDQAuI+c/bFMA9eXWIDPoXkMr w/HdNQFbb9zwUQ8HSg+0Smdz5O0Q5Wb3lKNLkSawGv0Nwdlj3rMCan8IMJk6dQ8p 8B2UgZLZznkVqjOGW+0yAdH+nBhhFbzvUA/PpJ/TwFiswG4h2ydGZz/aNqGj2WiX GFQJ/tyeAGSde6jlnq6gzQ9kqpOxxoBbkvSFXksMnpT9C7qVJWWK/SQV1wGclb9E OCVou/flwXDWMP465J5qh2kuJicqmppubGt0g4BJo6XahgCWRhpmNL2oJovCJ2nq pI6q0WKWjtA8Qmi5jmESKQK529iJYIFX+HbIV7dotJXcsmxFP1CFaxX7cnB/fuos 1xEHDQeDsWeS4xeLqlKao6Y3wOsZkDonackEYSyfJijNT+3Pdo8FVSosBR8u46ny MhoeNS7oMf+ri30BZ4E44iK5+FjnlBfKWrpbj2JNbCK1XRQhI1i0YI+4TUMsBDAU hbZykkSGd67KCnyuLiwPOdi7URfU53wBq0U2fDYb/o5UWZiZjsRzT7Lcm5j3iQZ4 nqF7vDpjkvOoWBrWH6TX+uc1QHFSW1PQ126aqqC8YKT6RkGEfLKcCnowitbRuAtr 9EegwbGxdJE4bKDAiZDl6mp2UK/iegJz8lAwt2+ugSvvOPbOJW4= =OFsC -----END PGP SIGNATURE----- --Apple-Mail=_561E7F91-CF57-44BE-B8F3-FC704AEDD3A9--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?2B7512A8-09EC-4A3B-B594-529E9354215E>