From owner-freebsd-arch@FreeBSD.ORG Mon Jan 9 13:48:27 2012 Return-Path: Delivered-To: freebsd-arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7DBD0106566B; Mon, 9 Jan 2012 13:48:27 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id 52DE08FC15; Mon, 9 Jan 2012 13:48:27 +0000 (UTC) Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [96.47.65.170]) by cyrus.watson.org (Postfix) with ESMTPSA id 070D746B06; Mon, 9 Jan 2012 08:48:27 -0500 (EST) Received: from jhbbsd.localnet (unknown [209.249.190.124]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 8A814B967; Mon, 9 Jan 2012 08:48:26 -0500 (EST) From: John Baldwin To: freebsd-arch@freebsd.org Date: Mon, 9 Jan 2012 07:57:29 -0500 User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110714-p10; KDE/4.5.5; amd64; ; ) References: In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201201090757.29250.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Mon, 09 Jan 2012 08:48:26 -0500 (EST) Cc: Adrian Chadd , Stefan Bethke Subject: Re: Where should I put ar71xx_* modules? X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Jan 2012 13:48:27 -0000 On Monday, January 09, 2012 4:04:14 am Adrian Chadd wrote: > On 9 January 2012 00:52, Stefan Bethke wrote: > > We have lots of modules that have specific requirements; they're still connected to the build. What warrants different handling here? You could put them under .if ${MACHINE_CPUARCH} != "mips" like a number of them are already. > > Hm, I didn't want to add modules for a specific SoC that won't ever be > built for any other platform. Eg, if someone does a XLR build, they > shouldn't get ar71xx modules built. Were you planning on including them in the ar71xx kernel configs via MODULES_OVERRIDE or some such? If so, that would be sufficient to get 'make tinderbox' to cover them at least (and hopefully tinderbox builds). In that case I think it is fine to not have them hooked up in the main sys/modules build. Or rather, if Warner commits his KERNOPTS thing, perhaps you could make sys/modules/Makefile include them on appropriate SoC kernels only. -- John Baldwin