From owner-cvs-all@FreeBSD.ORG Thu Oct 7 20:32:58 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BB0BD16A4CE; Thu, 7 Oct 2004 20:32:58 +0000 (GMT) Received: from ns1.xcllnt.net (209-128-86-226.bayarea.net [209.128.86.226]) by mx1.FreeBSD.org (Postfix) with ESMTP id 213F343D5C; Thu, 7 Oct 2004 20:32:58 +0000 (GMT) (envelope-from marcel@xcllnt.net) Received: from ns1.xcllnt.net (localhost [127.0.0.1]) by ns1.xcllnt.net (8.13.1/8.13.1) with ESMTP id i97KWpVi083355; Thu, 7 Oct 2004 13:32:51 -0700 (PDT) (envelope-from marcel@ns1.xcllnt.net) Received: (from marcel@localhost) by ns1.xcllnt.net (8.13.1/8.13.1/Submit) id i97KWppR083354; Thu, 7 Oct 2004 13:32:51 -0700 (PDT) (envelope-from marcel) Date: Thu, 7 Oct 2004 13:32:51 -0700 From: Marcel Moolenaar To: "M. Warner Losh" Message-ID: <20041007203251.GA83250@ns1.xcllnt.net> References: <20041007175206.GA82275@ns1.xcllnt.net> <20041007.122005.127628260.imp@bsdimp.com> <20041007190453.GA82804@ns1.xcllnt.net> <20041007.135813.110909154.imp@bsdimp.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20041007.135813.110909154.imp@bsdimp.com> User-Agent: Mutt/1.4.2.1i cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/sys pbioio.h src/sys/i386/isa pbio.c src/sys/conf files.i386 src/sys/i386/conf NOTES X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Oct 2004 20:32:58 -0000 On Thu, Oct 07, 2004 at 01:58:13PM -0600, M. Warner Losh wrote: > : > : > > : > : > Modified files: > : > : > sys/conf files.i386 > : > : > sys/i386/conf NOTES > : > : > Added files: > : > : > sys/sys pbioio.h > : > : > sys/i386/isa pbio.c > : > : > Log: > : > : > Port pbio to HEAD. > : > : > : > : I appreciate your speed, but don't you think that pbioio.h is pretty > : > : MD given that the driver only exists on i386. Wouldn't > : > : be a better place? > : > > : > I think that pbioio.h is MI. What makes you think that it is pretty > : > MD? > : > : Because pbio(4) only exists on i386. Hence, all other platforms now > : have that serves no purpose and can only cause > : autoconfiguration (ala autoconf) getting confused. Since pbioio.h > : refers to hardware, it nature is MD, even though the definitions > : (types and interfaces) may appear MI. So, seems > : like a good place. > > But we've had lots of problems in the past where MD drivers became MI > drivers with 10 identical copies of machine/fooio.h. The driver > likely copy become MI relatively easily. Speculation. Isn't it better to cross that bridge when you come to it? A repo-copy when the work has actually been done seems easy enough. Don't get me wrong. For all I care this driver is the next best thing since the invention of a round wheel, but the fact is that all people involved seem to worry about i386 only and even made it an isa only driver (based on it's location not on source code). That's a pretty limited scope to begin with and it doesn't exactly give me the warm fuzzies that the hardware is anywhere near MI nor that the driver grows MI. Hence my concern... Anyway: I'm not asking for a backout and you're not of the opinion that is better, so we can close this case anytime we like to. Feel free... -- Marcel Moolenaar USPA: A-39004 marcel@xcllnt.net