From owner-cvs-all Tue Jan 22 12:58:53 2002 Delivered-To: cvs-all@freebsd.org Received: from alcatraz.iptelecom.net.ua (alcatraz.iptelecom.net.ua [212.9.224.15]) by hub.freebsd.org (Postfix) with ESMTP id 8F4F937B402; Tue, 22 Jan 2002 12:58:40 -0800 (PST) Received: from ipcard.iptcom.net (ipcard.iptcom.net [212.9.224.5]) by alcatraz.iptelecom.net.ua (8.9.3/8.9.3) with ESMTP id WAA44790; Tue, 22 Jan 2002 22:58:24 +0200 (EET) (envelope-from sobomax@FreeBSD.org) Received: from vega.vega.com (h203.228.dialup.iptcom.net [212.9.228.203]) by ipcard.iptcom.net (8.9.3/8.9.3) with ESMTP id WAA14016; Tue, 22 Jan 2002 22:58:21 +0200 (EET) (envelope-from sobomax@FreeBSD.org) Received: from FreeBSD.org (big_brother.vega.com [192.168.1.1]) by vega.vega.com (8.11.6/8.11.3) with ESMTP id g0MKvoI22161; Tue, 22 Jan 2002 22:57:50 +0200 (EET) (envelope-from sobomax@FreeBSD.org) Message-ID: <3C4DD282.A1FA297C@FreeBSD.org> Date: Tue, 22 Jan 2002 22:58:42 +0200 From: Maxim Sobolev Organization: Vega International Capital X-Mailer: Mozilla 4.79 [en] (Windows NT 5.0; U) X-Accept-Language: en,uk,ru MIME-Version: 1.0 To: Will Andrews Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: ports/mail/evolution pkg-plist ports/mail/evolution/files patch-ac patch-camel::providers::local::Makefile.in patch-camel::providers::nntp::Makefile.in patch-camel::providers::pop3::Makefile.in patch-camel::providers::sendmail::Makefile.in patch-camel::providers::smtp::Makefile.in patch-mail::importers::Makefile.in References: <200201222039.g0MKdcm91935@freefall.freebsd.org> <20020122154603.H18609@squall.waterspout.com> Content-Type: text/plain; charset=koi8-r Content-Transfer-Encoding: 7bit Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Will Andrews wrote: > > On Tue, Jan 22, 2002 at 12:39:37PM -0800, Maxim Sobolev wrote: > > Revision Changes Path > > 1.1 +14 -0 ports/mail/evolution/files/patch-camel::providers::local::Makefile.in (new) > > 1.1 +14 -0 ports/mail/evolution/files/patch-camel::providers::nntp::Makefile.in (new) > > 1.1 +14 -0 ports/mail/evolution/files/patch-camel::providers::pop3::Makefile.in (new) > > 1.1 +14 -0 ports/mail/evolution/files/patch-camel::providers::sendmail::Makefile.in (new) > > 1.1 +14 -0 ports/mail/evolution/files/patch-camel::providers::smtp::Makefile.in (new) > > 1.1 +18 -0 ports/mail/evolution/files/patch-mail::importers::Makefile.in (new) > > Your patchfile names are needlessly long, IMO. Names are auto-generated, so I don't really care. > For example, each > of the above could have, instead, been: > > patch-local::Makefile.in > patch-nntp::Makefile.in > patch-pop3::Makefile.in > patch-sendmail::Makefile.in > patch-smtp::Makefile.in > patch-importers::Makefile.in > > Also, your patchfiles can be easily replaced with a perl regex. Well, considering that those patches are to be submitted back to developers this isn't a good idea either. -Maxim To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message