Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 22 Jan 2002 22:58:42 +0200
From:      Maxim Sobolev <sobomax@FreeBSD.org>
To:        Will Andrews <will@csociety.org>
Cc:        cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: ports/mail/evolution pkg-plist  ports/mail/evolution/files patch-ac  patch-camel::providers::local::Makefile.in  patch-camel::providers::nntp::Makefile.in  patch-camel::providers::pop3::Makefile.in  patch-camel::providers::sendmail::Makefile.in  patch-camel::providers::smtp::Makefile.in  patch-mail::importers::Makefile.in
Message-ID:  <3C4DD282.A1FA297C@FreeBSD.org>
References:  <200201222039.g0MKdcm91935@freefall.freebsd.org> <20020122154603.H18609@squall.waterspout.com>

next in thread | previous in thread | raw e-mail | index | archive | help
Will Andrews wrote:
> 
> On Tue, Jan 22, 2002 at 12:39:37PM -0800, Maxim Sobolev wrote:
> >   Revision  Changes    Path
> >   1.1       +14 -0     ports/mail/evolution/files/patch-camel::providers::local::Makefile.in (new)
> >   1.1       +14 -0     ports/mail/evolution/files/patch-camel::providers::nntp::Makefile.in (new)
> >   1.1       +14 -0     ports/mail/evolution/files/patch-camel::providers::pop3::Makefile.in (new)
> >   1.1       +14 -0     ports/mail/evolution/files/patch-camel::providers::sendmail::Makefile.in (new)
> >   1.1       +14 -0     ports/mail/evolution/files/patch-camel::providers::smtp::Makefile.in (new)
> >   1.1       +18 -0     ports/mail/evolution/files/patch-mail::importers::Makefile.in (new)
> 
> Your patchfile names are needlessly long, IMO.

Names are auto-generated, so I don't really care.

> For example, each
> of the above could have, instead, been:
> 
> patch-local::Makefile.in
> patch-nntp::Makefile.in
> patch-pop3::Makefile.in
> patch-sendmail::Makefile.in
> patch-smtp::Makefile.in
> patch-importers::Makefile.in
> 
> Also, your patchfiles can be easily replaced with a perl regex.

Well, considering that those patches are to be submitted back to
developers this isn't a good idea either.

-Maxim

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3C4DD282.A1FA297C>