From owner-freebsd-current@freebsd.org Sun Jul 15 19:09:43 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8BD5D104B89E for ; Sun, 15 Jul 2018 19:09:43 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-it0-x231.google.com (mail-it0-x231.google.com [IPv6:2607:f8b0:4001:c0b::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 0F5A993E60 for ; Sun, 15 Jul 2018 19:09:43 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-it0-x231.google.com with SMTP id v71-v6so18155814itb.3 for ; Sun, 15 Jul 2018 12:09:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=ygPDuz63ua8JDpGVg6WIHVj2M/tRJ0bpqXhDH2OXydM=; b=HHWK0t6t92v84p6U9SMZz4zLiUXTxet5lFM+UWZYvmF/4ZOEv6wTqBFiOQ/+wS3yrK cVvytKTJoB5jUvNGyCQToQoRNunfn0/merOeWTdKHnVh2BYzHS2GwRPK6I9aEFmMzlEt qHjEjXrMFLa41h3wxofCpbIa/mlAlCme3GxDdi0vvXNM0CApnspEVfSOcnkgMCfW+Pib qAFQwzZZvQoIskLl/Ww5h8Abin4yOh892IDStRpq9uryT8z2V3AFgjMXjJ/Zey5eAcFy yKLtr7DamQJZmznWTnAddN+C06ztAE2p5mC59iYR0j93OCgw4BR3dWAvdQRwtxElPyqx 1TBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=ygPDuz63ua8JDpGVg6WIHVj2M/tRJ0bpqXhDH2OXydM=; b=Yoy8cqpU7ynvKJWEj8KCGa66825cOtX62fnaVtu5BRuOIiBluD8e2U3FgKiADLRii+ /oyzb9NhEBAQogOzytdr+jsN62MbWA6jL3+YgxQXnyIsV7CGJth62g4o2btFnioOs4Ur S14ycolNTPBVDi8RBkTsLZuNcyDXBKGq58KQQQd64R9x1v2sdU3Xt5nu5yvd0wjdBScy qC+1P6/YSlySoe5DqB20/IDxj8E3Y9q9Qzd8icPc3FGwJiqotbXYdeePRP6wjprt6yRB DtXg2iu//VncVnjx8AfYT98zizloMyKZsrPzpMcugQbflLIpwUeXHSQtmu1ONtuW6E3x kiAA== X-Gm-Message-State: AOUpUlEUx7u61Vx3D1ITa2yN44aG5hFKa5/YmkrUB0qwI7uRpyJPJYAJ rEX33bDULZlGYVf9wi5XQVv8Yp16kHAi806/ucGuRQ== X-Google-Smtp-Source: AAOMgpe+wzeHCdLqSIp5BIvdiVvOQ8eHOA79732WveNO0yVffZsNQQgvfphHIJagACZVLy4I1ZFKiUF1kZ+/GjvkiJ4= X-Received: by 2002:a02:3344:: with SMTP id k4-v6mr12337458jak.45.1531681782105; Sun, 15 Jul 2018 12:09:42 -0700 (PDT) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 2002:a4f:1183:0:0:0:0:0 with HTTP; Sun, 15 Jul 2018 12:09:41 -0700 (PDT) X-Originating-IP: [2603:300b:6:5100:1052:acc7:f9de:2b6d] In-Reply-To: <20180715184255.4965AE50@spqr.komquats.com> References: <20180715184255.4965AE50@spqr.komquats.com> From: Warner Losh Date: Sun, 15 Jul 2018 13:09:41 -0600 X-Google-Sender-Auth: IDl-3p7-GR8OnGuh6AOhBKj0tTg Message-ID: Subject: Re: [PATCH] Recent libm additions To: Cy Schubert Cc: Ian Lepore , "K. Macy" , Steve Kargl , FreeBSD Current Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.27 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Jul 2018 19:09:43 -0000 I'm not saying that he has a lock. I'm saying he's are domain expert and many mistakes can be avoided by talking to him. I'm saying we have history here, and that history, while poorly documented, wasn't followed. To the extent it is poorly documented, we should fix that. Warner On Sun, Jul 15, 2018 at 12:43 PM, Cy Schubert wrote: > I don't think it makes sense for a non-committer to have a lock on > anything in base. However a request for review makes a lot of sense. If a > non-committer or former committer is the SME on a particular subject it's > best that they be consulted even if they don't request it. IMO more input > is better. Where better to document this than in MAINTAINERS. > > Having said all this. If a person is a former committer and it's not > documented, how are we to know? > > If people agree, should we start documenting SMEs in MAINTAINERS? > > --- > Sent using a tiny phone keyboard. > Apologies for any typos and autocorrect. > Also, this old phone only supports top post. Apologies. > > Cy Schubert > or > The need of the many outweighs the greed of the few. > --- > ------------------------------ > From: Ian Lepore > Sent: 15/07/2018 11:08 > To: Warner Losh; K. Macy > Cc: Steve Kargl; FreeBSD Current > Subject: Re: [PATCH] Recent libm additions > > On Sun, 2018-07-15 at 11:55 -0600, Warner Losh wrote: > > On Sun, Jul 15, 2018, 11:23 AM K. Macy wrote: > > > > > > > > > > > > > > > > > Well, actually, the functions in polevll.c should have been > > > > copied > > > > into ld80/e_powl.c, and polevall.c should never have been > > > > committed. > > > > Unfortunately, the code was not reviewed for correctness. > > > That is not correct. Please stop repeating it. Bruce Evans and John > > > Baldwin were both looped in. Neither made this observation. > > > > > Steve is the fp guy these days. And it wasn't reviewed by him. He's > > mad you > > cut him out of the loop. Arguing about pedantic points of process > > does no > > one any good. > > > > Warner > > On the other hand, what information is there for someone to know that > Steve should be involved in a review? There is nothing in MAINTAINERS. > The review was on phab for almost a month, and phab is supposedly the > preferred way to do reviews these days. > > Steve is no longer a committer, but that doesn't preclude him having a > phab account and participating in reviews. If he doesn't like using > phab (and I can certainly understand that POV), an entry in MAINTAINERS > would still be helpful, unless we have a rule that only committers can > be listed in there. > > -- Ian > > _______________________________________________ > freebsd-current@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-current > To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org" > >