From owner-freebsd-ports Sat Mar 1 11:32:34 2003 Delivered-To: freebsd-ports@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 43EE137B401 for ; Sat, 1 Mar 2003 11:32:33 -0800 (PST) Received: from analog.databits.net (analog.databits.net [198.78.65.155]) by mx1.FreeBSD.org (Postfix) with SMTP id 46B0E43F93 for ; Sat, 1 Mar 2003 11:32:32 -0800 (PST) (envelope-from petef@analog.databits.net) Received: (qmail 18948 invoked by uid 1000); 1 Mar 2003 19:31:12 -0000 Date: Sat, 1 Mar 2003 13:31:12 -0600 From: Pete Fritchman To: Kris Kennaway Cc: ports@FreeBSD.org, mharo@FreeBSD.org Subject: Re: portlint and pre-everything: (Re: cvs commit: ports/audio/audacity Makefile ports/audio/evilbar Makefile ports/audio/mp3blaster Makefile ports/audio/snack Makefile ports/audio/terminatorx Makefile ports/databases/firebird Makefile ports/devel/autoconf Makefile ports/devel/autoconf213 ...) Message-ID: <20030301193112.GB26685@absolutbsd.org> References: <200302282253.h1SMr2IC002468@repoman.freebsd.org> <20030228225638.GA88341@rot13.obsecurity.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20030228225638.GA88341@rot13.obsecurity.org> User-Agent: Mutt/1.4i Sender: owner-freebsd-ports@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org ++ 28/02/03 14:56 -0800 - Kris Kennaway: | On Fri, Feb 28, 2003 at 02:53:02PM -0800, Kris Kennaway wrote: | | > Log: | > Use pre-everything:: instead of pre-everything: to avoid conflict with | > targets in bsd.port.mk | | portlint should be updated to warn about this. Can someone do this? How about this? %% Index: src/portlint.pl =================================================================== RCS file: /home/pcvs/ports/devel/portlint/src/portlint.pl,v retrieving revision 1.34 diff -u -u -r1.34 portlint.pl --- src/portlint.pl 10 Feb 2003 08:58:30 -0000 1.34 +++ src/portlint.pl 1 Mar 2003 19:31:45 -0000 @@ -1527,6 +1527,11 @@ "discouraged. redefine \"do-$1\" instead."); } + # check for incorrect use of the pre-everything target. + if ($tmp =~ /\npre-everything:[^:]/) { + &perror("FATAL: use pre-everything:: instead of pre-everything:"); + } + 1; } %% --pete To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message