From owner-freebsd-current@freebsd.org Fri Jul 5 14:31:35 2019 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9E0B615CC0F4 for ; Fri, 5 Jul 2019 14:31:35 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com [209.85.167.45]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 61AEA71B1F; Fri, 5 Jul 2019 14:31:34 +0000 (UTC) (envelope-from asomers@gmail.com) Received: by mail-lf1-f45.google.com with SMTP id q26so6473947lfc.3; Fri, 05 Jul 2019 07:31:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2P131pVAMOD1RLf+jxYXBwWplYRqY63n77kgtRRigt8=; b=VOw+GPdISx2J+hKAOUQH/8FKC3HVBNSPRNNDoYpvDQ9L9y5Hq7KfoU8cB2Ahcog3H6 f7uc/Gz9VG1Eb5CALp+fd6vI9OOeOn8hL8tPZ0QmDOxQuAlRj3Gt1NpUumr2o6uHQM3C 0jAqZdRLxJwT2TN3ro+sMEl/QDXk0kfI4IrZY12+nuJ7wATJJ0pfR3GUI2QvzVxR4zdk F5ID3X/tvTJrGWgRtJd0RgWFXinnp79JP2nG+s+0EKWs3Gf1nzhQd+7hgYJE4T328ZEX 5um3Fp1DZCRnqplokCSB1Ug/t9u4HvhqTNev9XHwq59WM69NTJUmPgoaWbsB3olQnT1J hxTQ== X-Gm-Message-State: APjAAAU5SC1uAs7XjEknV9fvI4nFu9PWWLtjXt5caiqaMjuX+inwN2YU j28De/YzWBcfvHk7cp8191zASXFd2+ygTzwm8bw= X-Google-Smtp-Source: APXvYqzpM6jO44MUcJkuXNJy7MmXCSMHSKIdT1EEgDJ5T3cRDyTuJnWModlTB3RsukZJ8dfobzhh70jgHHLEpZcOTIQ= X-Received: by 2002:a19:7509:: with SMTP id y9mr2191279lfe.117.1562337086839; Fri, 05 Jul 2019 07:31:26 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Alan Somers Date: Fri, 5 Jul 2019 08:31:15 -0600 Message-ID: Subject: Re: test program for copy_file_range(2) To: Rick Macklem Cc: "freebsd-current@FreeBSD.org" , "kib@freebsd.org" Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 61AEA71B1F X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; spf=pass (mx1.freebsd.org: domain of asomers@gmail.com designates 209.85.167.45 as permitted sender) smtp.mailfrom=asomers@gmail.com X-Spamd-Result: default: False [-2.81 / 15.00]; ARC_NA(0.00)[]; TO_DN_EQ_ADDR_SOME(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; RCVD_TLS_LAST(0.00)[]; DMARC_NA(0.00)[freebsd.org]; TO_DN_SOME(0.00)[]; NEURAL_SPAM_SHORT(0.50)[0.499,0]; TO_MATCH_ENVRCPT_SOME(0.00)[]; MX_GOOD(-0.01)[cached: alt3.gmail-smtp-in.l.google.com]; RCVD_IN_DNSWL_NONE(0.00)[45.167.85.209.list.dnswl.org : 127.0.5.0]; IP_SCORE(-1.30)[ip: (-0.57), ipnet: 209.85.128.0/17(-3.46), asn: 15169(-2.40), country: US(-0.06)]; FORGED_SENDER(0.30)[asomers@freebsd.org,asomers@gmail.com]; MIME_TRACE(0.00)[0:+]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; FROM_NEQ_ENVFROM(0.00)[asomers@freebsd.org,asomers@gmail.com]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Jul 2019 14:31:35 -0000 On Thu, Jul 4, 2019 at 6:38 PM Rick Macklem wrote: > > I have a little program for testing the copy_file_range(2) syscall I've been > working on. (The current version is attached, in case anyone is interested.) > > It take a few minutes to run on a slow system and uses about 6Gbytes of disk > space for the file system the output file is on. (It creates 2 files to use for testing. > The first one is sparse and the second is copied from it, but grows as different byte > ranges get copied, since "punching holes" is done via writes of 0 bytes.) > > My question is.. > What needs to be done to include this in FreeBSD? > I see some stuff under head/tests. I could probably figure out > what the macros in those files are, but I can only see tests to see if > arguments are valid and similar. As such, I'm not sure if this is the correct > place for a test like this? > > Thanks for any help with this, rick head/tests is for complete automated tests, mostly in ATF format. Your program sounds more like the kind of helper program that might be more suitable for head/tools/regression. Those programs all require some operator interaction. If you can automate your program then we should add it to head/tests/sys. Does it really need 6GB to get decent test coverage? -Alan