From owner-freebsd-current@freebsd.org Sat Nov 4 20:13:10 2017 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 652F9E54956 for ; Sat, 4 Nov 2017 20:13:10 +0000 (UTC) (envelope-from markmi@dsl-only.net) Received: from asp.reflexion.net (outbound-mail-210-155.reflexion.net [208.70.210.155]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 1358580B4C for ; Sat, 4 Nov 2017 20:13:09 +0000 (UTC) (envelope-from markmi@dsl-only.net) Received: (qmail 10447 invoked from network); 4 Nov 2017 20:13:03 -0000 Received: from unknown (HELO mail-cs-02.app.dca.reflexion.local) (10.81.19.2) by 0 (rfx-qmail) with SMTP; 4 Nov 2017 20:13:03 -0000 Received: by mail-cs-02.app.dca.reflexion.local (Reflexion email security v8.40.3) with SMTP; Sat, 04 Nov 2017 16:13:03 -0400 (EDT) Received: (qmail 26856 invoked from network); 4 Nov 2017 20:13:02 -0000 Received: from unknown (HELO iron2.pdx.net) (69.64.224.71) by 0 (rfx-qmail) with (AES256-SHA encrypted) SMTP; 4 Nov 2017 20:13:02 -0000 Received: from [192.168.1.25] (c-76-115-7-162.hsd1.or.comcast.net [76.115.7.162]) by iron2.pdx.net (Postfix) with ESMTPSA id 276A7EC86EF; Sat, 4 Nov 2017 13:13:02 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\)) Subject: Re: svn commit: r325320 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs [breaks lld on zfs: lld uses fallocate] From: Mark Millard In-Reply-To: Date: Sat, 4 Nov 2017 13:13:01 -0700 Cc: Andriy Gapon , FreeBSD Toolchain , "svn-src-head@freebsd.org" , FreeBSD Current Content-Transfer-Encoding: quoted-printable Message-Id: <9D762BA9-D957-4413-98E1-E4410BA20112@dsl-only.net> References: <6140C4E2-168F-4E5D-B3C2-717ECB67C980@dsl-only.net> <134eea8e-1a2e-d77c-f7fa-01e14db7f47b@FreeBSD.org> To: Ed Maste X-Mailer: Apple Mail (2.3273) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 04 Nov 2017 20:13:10 -0000 On 2017-Nov-4, at 4:58 AM, Ed Maste wrote: > On 4 November 2017 at 07:41, Andriy Gapon wrote: >> On 04/11/2017 12:32, Mark Millard wrote: >>> if (int Err =3D ::posix_fallocate(FD, 0, Size)) { >>> if (Err !=3D EOPNOTSUPP) >>> return std::error_code(Err, std::generic_category()); >>> } >>=20 >> The commit message that you didn't include into your reply contains = some useful >> information that authors / maintainers of this code should probably = take into >> account: >>=20 >>> Please note that EINVAL is used to report that the underlying file = system >>> does not support the operation (POSIX.1-2008). >>=20 >> Here is a link for that: >> = http://pubs.opengroup.org/onlinepubs/9699919799/functions/posix_fallocate.= html >=20 > I have no idea how they decided EINVAL was a reasonable errno for this = case. I think they viewed it as a bad fd argument: a reference into a wrong file system, much like a wrong len (<0) or offset (<0). That there is no other means of run-time classifying the file system(s)(?) was not viewed as sufficient reason to give it a different classification. But it is just a guess. =3D=3D=3D Mark Millard markmi at dsl-only.net