Date: Mon, 14 Jul 2014 22:01:58 +0200 From: "Timur I. Bakeyev" <timur@FreeBSD.org> To: Steve Wills <swills@freebsd.org> Cc: svn-ports-head <svn-ports-head@freebsd.org>, svn-ports-all <svn-ports-all@freebsd.org>, marino@freebsd.org, "ports-committers@freebsd.org" <ports-committers@freebsd.org> Subject: Re: svn commit: r361646 - in head/net/samba36: . files Message-ID: <CALdFvJEvf4-RSJNUVxX08T8K-tq9PoKge-XxmhDafAn_QxjEcg@mail.gmail.com> In-Reply-To: <20140714003112.GA54756@mouf.net> References: <201407122229.s6CMTN42057554@svn.freebsd.org> <CALdFvJGQq=PNpAqBBEZXi-q0GT=Ro-fRSjGcHFR1R01=FBtQOQ@mail.gmail.com> <53C322A7.2090705@marino.st> <20140714003112.GA54756@mouf.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Jul 14, 2014 at 2:31 AM, Steve Wills <swills@freebsd.org> wrote: > On Mon, Jul 14, 2014 at 02:21:59AM +0200, John Marino wrote: > > On 7/14/2014 02:12, Timur I. Bakeyev wrote: > > > WTF?! > > > > > > Where is the bug report or anything alike? > > > > You know the general blanket covers stuff like shebang fixes, right? > > Yeah, this was meant to be covered under the general "fix it" blanket > approval. > Sorry for the confusion. > > Your fix is wrong on so many levels, I can't even count. First - you supposed to tell me at least, what exactly the problem you trying to fix. Or describe it in your commit thoroughly if you can't resist committing. You bumped PORTREVISION, although there wasn't any pkg list change - so all the users now have to recompile not so tiny samba36 just to fix shebang in one rarely used file. There are 3 versions of samba, more or less sharing codebase - now I have no idea, is there a problem with samba4 and/or samba41. There are better ways to fix shebang issues - "USES = shebangfix" is the correct way to use, instead of inplace replacement. @PERL@ suggests that the problem is in autotools detection of the Perl location, so even better fix would be CONFIGURE_ENV="PERL=$LOCALBASE/bin/perl" And the cherry at the top of the cake and my WTF was about it: Added: head/net/samba36/files/patch-source3__script__findsmb.in ============================================================================== --- /dev/null 00:00:00 1970 (empty, because file is newly added) +++ head/net/samba36/files/patch-source3__script__findsmb.in Sat Jul 12 22:29:23 2014 (r361646) @@ -0,0 +1,8 @@ +--- ./source3/script/findsmb.in.orig 2014-07-12 21:37:56.512194098 +0000 ++++ ./source3/script/findsmb.in 2014-07-12 21:38:19.976192656 +0000 +@@ -1,4 +1,4 @@ +-#!@PERL@ ++#!%%PREFIX%%/bin/perl + # + # Prints info on all smb responding machines on a subnet. + # This script needs to be run on a machine without nmbd running and be You'd never use $PREFIX to refer to installed parts of the ports tree. There is $LOCALBASE exactly for that and in general PREFIX!=LOCALBASE. So, the whole commit IMHO can be thrown into the trash. Regards, still(?) samba ports maintainer.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CALdFvJEvf4-RSJNUVxX08T8K-tq9PoKge-XxmhDafAn_QxjEcg>