From owner-freebsd-emulation@FreeBSD.ORG  Fri Feb 20 12:23:04 2009
Return-Path: <owner-freebsd-emulation@FreeBSD.ORG>
Delivered-To: freebsd-emulation@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 518921065674
	for <freebsd-emulation@FreeBSD.org>;
	Fri, 20 Feb 2009 12:23:04 +0000 (UTC)
	(envelope-from rdivacky@vlk.vlakno.cz)
Received: from vlakno.cz (77-93-215-190.static.masterinter.net [77.93.215.190])
	by mx1.freebsd.org (Postfix) with ESMTP id 0D50E8FC12
	for <freebsd-emulation@FreeBSD.org>;
	Fri, 20 Feb 2009 12:23:03 +0000 (UTC)
	(envelope-from rdivacky@vlk.vlakno.cz)
Received: from localhost (localhost [127.0.0.1])
	by vlakno.cz (Postfix) with ESMTP id 8C3949CB06B;
	Fri, 20 Feb 2009 13:19:58 +0100 (CET)
X-Virus-Scanned: amavisd-new at vlakno.cz
Received: from vlakno.cz ([127.0.0.1])
	by localhost (lev.vlakno.cz [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id glMyJnCrPMZc; Fri, 20 Feb 2009 13:19:52 +0100 (CET)
Received: from vlk.vlakno.cz (localhost [127.0.0.1])
	by vlakno.cz (Postfix) with ESMTP id CADBE9CB112;
	Fri, 20 Feb 2009 13:19:52 +0100 (CET)
Received: (from rdivacky@localhost)
	by vlk.vlakno.cz (8.14.3/8.14.3/Submit) id n1KCJqxH070579;
	Fri, 20 Feb 2009 13:19:52 +0100 (CET) (envelope-from rdivacky)
Date: Fri, 20 Feb 2009 13:19:52 +0100
From: Roman Divacky <rdivacky@FreeBSD.org>
To: Ed Schouten <ed@80386.nl>
Message-ID: <20090220121952.GA70382@freebsd.org>
References: <20090219205645.GF19161@hoeg.nl> <20090219212749.GI19161@hoeg.nl>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20090219212749.GI19161@hoeg.nl>
User-Agent: Mutt/1.4.2.3i
Cc: freebsd-emulation@FreeBSD.org
Subject: Re: Making Linux stat() less evil
X-BeenThere: freebsd-emulation@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Development of Emulators of other operating systems
	<freebsd-emulation.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-emulation>, 
	<mailto:freebsd-emulation-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-emulation>
List-Post: <mailto:freebsd-emulation@freebsd.org>
List-Help: <mailto:freebsd-emulation-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-emulation>, 
	<mailto:freebsd-emulation-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 20 Feb 2009 12:23:05 -0000

On Thu, Feb 19, 2009 at 10:27:49PM +0100, Ed Schouten wrote:
> Roman,
> 
> After some discussion with kib@ on IRC, I changed the patch a little: I
> added a new function called kern_statat_vnhook(). This function allows
> the Linuxolator to use a hook to modify struct stat, to reduce some
> redundant code:
> 
> 	http://80386.nl/pub/linux-stat.diff

looks ok to me.. I'd just use __predict_false() to the condition
in the kern_statat_vnhook() so we dont pessimise the typical case

I didnt test though (nor I plan to)