From owner-freebsd-current@FreeBSD.ORG Mon Jan 9 17:36:06 2006 Return-Path: X-Original-To: freebsd-current@freebsd.org Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9612C16A41F; Mon, 9 Jan 2006 17:36:06 +0000 (GMT) (envelope-from cracauer@schlepper.zs64.net) Received: from schlepper.zs64.net (schlepper.zs64.net [212.12.50.230]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8075343D46; Mon, 9 Jan 2006 17:36:05 +0000 (GMT) (envelope-from cracauer@schlepper.zs64.net) Received: from schlepper.zs64.net (schlepper [212.12.50.230]) by schlepper.zs64.net (8.13.3/8.12.9) with ESMTP id k09Ha2sq019621; Mon, 9 Jan 2006 18:36:02 +0100 (CET) (envelope-from cracauer@schlepper.zs64.net) Received: (from cracauer@localhost) by schlepper.zs64.net (8.13.3/8.12.9/Submit) id k09Ha2rt019620; Mon, 9 Jan 2006 12:36:02 -0500 (EST) (envelope-from cracauer) Date: Mon, 9 Jan 2006 12:36:02 -0500 From: Martin Cracauer To: =?iso-8859-1?Q?Dag-Erling_Sm=F8rgrav?= Message-ID: <20060109123602.A19382@cons.org> References: <20051229221459.A17102@cons.org> <868xu22mmp.fsf@xps.des.no> <200512301856.28800.jhb@freebsd.org> <200512310115.40490.jhb@freebsd.org> <20051231015102.A51804@cons.org> <43B66EF1.4020906@freebsd.org> <20060109113634.A17206@cons.org> <86ace5mibg.fsf@xps.des.no> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit User-Agent: Mutt/1.2.5i In-Reply-To: <86ace5mibg.fsf@xps.des.no>; from des@des.no on Mon, Jan 09, 2006 at 06:17:55PM +0100 Cc: Martin Cracauer , freebsd-current@freebsd.org, Colin Percival Subject: Re: fetch extension - use local filename from content-dispositionheader (new diff) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Jan 2006 17:36:06 -0000 Dag-Erling Smørgrav wrote on Mon, Jan 09, 2006 at 06:17:55PM +0100: > Martin Cracauer writes: > > To make people a little happier, I changed the meaning of the -O > > flag. > > > > Previously giving this non-argument -O flag would use the > > Content-Disposition header after a basic safey check. > > > > Now this flag takes an expected filename as an argument. If the > > argument is given, the server-supplied name will only be used if it > > matches the expected filename. If it doesn't the transport is aborted > > after reading the header. > > All my objections (including those related to breaking the ABI and the > -r option) still stand. I really like your discussion style. Omitting technical details and making nebulous statements triggering what you consider fear factors in the audience. I don't "break" the -r option. It just happens not to work in combination with the -O option. If you had read my diff you would see that I forbid both -m and -r in combination with -O and document this in the manpage. %% As for the ABI incompatibility (now that you at least admit it's the ABI and not the API as you previously claimed), the only reason why it is an incompatible change when the library is newer than the application (it's fine the other way round) is that *you* chose an interface design that locks libfetch against supporting any kind of future HTTP headers or extensions without ABI change. I don't think the FreeBSD operating system can accept getting locked down this way. Now, for technical solutions, I previously offered you to redesign the interface so that it would be extensible in ABI and API compatible manners - which you did not reply to. Personally I wouldn't bother since all two clients using libfetch (fetch and sysinstall) are part of the base system, so lets just bump the shared library version number and get it over with. If you can point me to other software using libfetch I would be happy to design said non-locked interface. Martin -- %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%% Martin Cracauer http://www.cons.org/cracauer/ FreeBSD - where you want to go, today. http://www.freebsd.org/