From owner-svn-src-all@freebsd.org Tue Aug 4 14:06:19 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 52F6D9B2505; Tue, 4 Aug 2015 14:06:19 +0000 (UTC) (envelope-from etnapierala@gmail.com) Received: from mail-wi0-x230.google.com (mail-wi0-x230.google.com [IPv6:2a00:1450:400c:c05::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id E2EC58CC; Tue, 4 Aug 2015 14:06:18 +0000 (UTC) (envelope-from etnapierala@gmail.com) Received: by wibud3 with SMTP id ud3so25499769wib.0; Tue, 04 Aug 2015 07:06:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:mail-followup-to :references:mime-version:content-type:content-disposition :in-reply-to:user-agent; bh=RyI4VtqGKIMszuyYcUwHCnoGEM7wNsWri1aCU23GwnM=; b=ZdqJqQh9hmWlEkL+zbes/GoTB0BnnOyF4E0k6h/xPg3vVwSkHFPaq2GT3NbLh1BjQw SLhJb924XWAXCedhb6tGZCNSt2RZl3iDdzodeadxbQTBFNxVFvDX2ADqpU0TRexiEexx c0vtuRbIE145cwZgB3QjA/e8op/PtTqHN4aMra+BDmcwd0i8zaW/jPEXVzO0lpGj3shr KbcNNR9nY+tfSUdyhbsLdwrkTtihquOcL4PY1wXkgJ3Xc07gxox4fiYE28TemBb/WuGz wwFN61Iitu0v+WNdRdDspfTw8b25pstjSasOHFf2Jcl9GdxLnr5vRbqDLxpsZXCxuv/a In8Q== X-Received: by 10.194.23.167 with SMTP id n7mr8191124wjf.112.1438697177392; Tue, 04 Aug 2015 07:06:17 -0700 (PDT) Received: from brick.home (ess151.neoplus.adsl.tpnet.pl. [83.20.138.151]) by smtp.gmail.com with ESMTPSA id ck18sm2009114wjb.47.2015.08.04.07.06.15 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 04 Aug 2015 07:06:16 -0700 (PDT) Sender: =?UTF-8?Q?Edward_Tomasz_Napiera=C5=82a?= Date: Tue, 4 Aug 2015 16:06:12 +0200 From: Edward Tomasz Napierala To: Andriy Gapon Cc: src-committers@FreeBSD.org, svn-src-all@FreeBSD.org, svn-src-head@FreeBSD.org Subject: Re: svn commit: r286234 - head/sys/boot/common Message-ID: <20150804140612.GA13928@brick.home> Mail-Followup-To: Andriy Gapon , src-committers@FreeBSD.org, svn-src-all@FreeBSD.org, svn-src-head@FreeBSD.org References: <201508031627.t73GRbTB092225@repo.freebsd.org> <55BFAAEB.2020900@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55BFAAEB.2020900@FreeBSD.org> User-Agent: Mutt/1.5.23 (2014-03-12) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Aug 2015 14:06:19 -0000 On 0803T2054, Andriy Gapon wrote: > On 03/08/2015 19:27, Edward Tomasz Napierala wrote: > > Author: trasz > > Date: Mon Aug 3 16:27:36 2015 > > New Revision: 286234 > > URL: https://svnweb.freebsd.org/changeset/base/286234 > > > > Log: > > Fix a problem which made loader(8) load non-kld files twice. > > What was the problem? > The change looks like defensive coding, but it's not clear why the loader would > attempt to load the same file more than once in the first place. It's because the "load_modules" Forth word gets called twice. It could be fixed, I guess, but I'm no good at Forth, so I chose the other way: I made the "load" command behave consistently; it already silently refused to load KLDs twice, and I made it behave the same way for other types of modules.