From owner-cvs-all  Thu Mar 23 23:56:58 2000
Delivered-To: cvs-all@freebsd.org
Received: from axl.ops.uunet.co.za (axl.ops.uunet.co.za [196.31.1.175])
	by hub.freebsd.org (Postfix) with ESMTP
	id 0497B37B562; Thu, 23 Mar 2000 23:56:34 -0800 (PST)
	(envelope-from sheldonh@axl.ops.uunet.co.za)
Received: from sheldonh (helo=axl.ops.uunet.co.za)
	by axl.ops.uunet.co.za with local-esmtp (Exim 3.13 #1)
	id 12YOx9-000JpO-00; Fri, 24 Mar 2000 09:56:19 +0200
From: Sheldon Hearn <sheldonh@uunet.co.za>
To: Wolfram Schneider <wosch@panke.de.freebsd.org>
Cc: Peter Wemm <peter@FreeBSD.ORG>, cvs-committers@FreeBSD.ORG,
	cvs-all@FreeBSD.ORG
Subject: Re: cvs commit: src/usr.sbin/adduser rmuser.perl 
In-reply-to: Your message of "Thu, 23 Mar 2000 21:15:18 +0100."
             <20000323211518.A1245@paula.panke.de.freebsd.org> 
Date: Fri, 24 Mar 2000 09:56:19 +0200
Message-ID: <76221.953884579@axl.ops.uunet.co.za>
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG



On Thu, 23 Mar 2000 21:15:18 +0100, Wolfram Schneider wrote:

> >   MFC: fix a bad regexp that failed on valid names.
> 
> After this change you cannot delete the user `foo-bar' anymore.
> Also, \w is not the same as a-zA-Z0-9_ 
> \w may contain locale characters.

My bad.  I suggested the use of \w to Mark Newton, not realizing the
full implications you point out.

We probably want

	if ($login_name !~ /^[a-zA-Z0-9_][a-zA-Z0-9_-]*$/);

if we don't want usernames to start with '-', or

	if ($login_name !~ /^[a-zA-Z0-9_-]+$/);

if we don't care.

Ciao,
Sheldon.


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message