From owner-freebsd-hackers  Fri Aug 27  9:46:23 1999
Delivered-To: freebsd-hackers@freebsd.org
Received: from ns.mt.sri.com (ns.mt.sri.com [206.127.79.91])
	by hub.freebsd.org (Postfix) with ESMTP id 6D0DC14C1E
	for <freebsd-hackers@FreeBSD.ORG>; Fri, 27 Aug 1999 09:46:19 -0700 (PDT)
	(envelope-from nate@mt.sri.com)
Received: from mt.sri.com (rocky.mt.sri.com [206.127.76.100])
	by ns.mt.sri.com (8.8.8/8.8.8) with SMTP id KAA07532
	for <freebsd-hackers@FreeBSD.ORG>; Fri, 27 Aug 1999 10:44:01 -0600 (MDT)
	(envelope-from nate@rocky.mt.sri.com)
Received: by mt.sri.com (SMI-8.6/SMI-SVR4)
	id KAA24087; Fri, 27 Aug 1999 10:44:01 -0600
Date: Fri, 27 Aug 1999 10:44:01 -0600
Message-Id: <199908271644.KAA24087@mt.sri.com>
From: Nate Williams <nate@mt.sri.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
To: freebsd-hackers@FreeBSD.ORG
Subject: Re: Please review: rc file changes
In-Reply-To: <199908271052.MAA02639@dorifer.heim3.tu-clausthal.de>
References: <199908271052.MAA02639@dorifer.heim3.tu-clausthal.de>
X-Mailer: VM 6.34 under 19.16 "Lille" XEmacs Lucid
Reply-To: nate@mt.sri.com (Nate Williams)
Sender: owner-freebsd-hackers@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

>  > [...]
>  > 2. value ) instead of value) for case statements
>  > [...]
>  >  	case $? in
>  > -	0)
>  > +		0 )
>  >  		;;
>  > -	2)
>  > +		2 )
>  >  		exit 1
>  >  		;;
>  > -	4)
>  > +		4 )
>  >  		reboot
>  >  		echo "reboot failed... help!"
>  >  		exit 1
>  >  		;;
>  > [...]
> 
> Why?!?  I like the existing "case" style _much_ better,
> it's more readable and emphasizes the structure.

And it is more conformant to 'style(9)', which says that the case
statements line up with the switch statement.  (Although that's for C
code, in this case I believe the sh code can be compliant indirectly...)



Nate


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-hackers" in the body of the message