From owner-freebsd-bugs Tue Jan 30 0:30:21 2001 Delivered-To: freebsd-bugs@hub.freebsd.org Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21]) by hub.freebsd.org (Postfix) with ESMTP id 0262937B4AB for ; Tue, 30 Jan 2001 00:30:03 -0800 (PST) Received: (from gnats@localhost) by freefall.freebsd.org (8.11.1/8.11.1) id f0U8U3A81441; Tue, 30 Jan 2001 00:30:03 -0800 (PST) (envelope-from gnats) Date: Tue, 30 Jan 2001 00:30:03 -0800 (PST) Message-Id: <200101300830.f0U8U3A81441@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org Cc: From: Peter Pentchev Subject: Re: bin/24707: [patch] Whois IP Address Handling Reply-To: Peter Pentchev Sender: owner-freebsd-bugs@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org The following reply was made to PR bin/24707; it has been noted by GNATS. From: Peter Pentchev To: Mike Barcroft Cc: FreeBSD-gnats-submit@freebsd.org Subject: Re: bin/24707: [patch] Whois IP Address Handling Date: Tue, 30 Jan 2001 10:24:55 +0200 On Mon, Jan 29, 2001 at 11:31:26AM -0500, Mike Barcroft wrote: > > > Just a little comment - I think in checking for dotted-quad IP addresses > > you should be doing just that - check for dotted quads, not just check > > for a starting digit. Yes, I know that the RFC's forbid - or at least > > express a mild disagreement - with labels starting with a digit, but > > in the real world, your patch would break e.g. 'whois 42.com' :( > > Not true. The patch checks the TLD, so 42.com works and 10.0.0.0 goes to > ARIN. Since a TLD is never going to be a digit, it's safe to assume that > it's an IP address. Oops. You're right, sorry. I promise I'll actually read the code next time :) G'luck, Peter -- Do you think anybody has ever had *precisely this thought* before? To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message