Date: Wed, 30 Mar 2011 14:31:33 +0200 (CEST) From: olli hauer <ohauer@FreeBSD.org> To: <FreeBSD-gnats-submit@FreeBSD.org> Cc: ohauer@FreeBSD.org Subject: ports/156057: [patch] port www/mod_uid does not build with apache20/22 Message-ID: <20110330123141.83EFB1065673@hub.freebsd.org> Resent-Message-ID: <201103301240.p2UCeA4b003289@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 156057
>Category: ports
>Synopsis: [patch] port www/mod_uid does not build with apache20/22
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Wed Mar 30 12:40:10 UTC 2011
>Closed-Date:
>Last-Modified:
>Originator: Olli Hauer
>Release:
>Organization:
>Environment:
>Description:
mod_uid does not build against apache20/22 but
"USE_APACHE= 1.3+" is defined in Makefile.
Build against apache13 is OK.
I suspect the module is not widly used in combination with
apache20/22 so I can think about two solutions.
- mark port broken for apache > 13
- set USE_APACHE= 13 (remove '+')
Snippet from build log against apache20
===> Building for ap20-mod_uid-1.1.0
===> Generating apache plist
/usr/local/share/apr/build-0/libtool --silent --mode=compile cc -prefer-pic -O2 -pipe -fno-strict-aliasing -DAP_HAVE_DESIGNATED_INITIALIZER -D_REENTRANT -D_THREAD_SAFE -g -pthrea
mod_uid.c:66: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'uid_module'
mod_uid.c: In function 'make_cookie':
mod_uid.c:142: error: request for member 'sin_addr' in something not a structure or union
mod_uid.c:163: warning: cast to pointer from integer of different size
mod_uid.c:173: error: 'ap_day_snames' undeclared (first use in this function)
mod_uid.c:173: error: (Each undeclared identifier is reported only once
mod_uid.c:173: error: for each function it appears in.)
mod_uid.c:174: error: 'ap_month_snames' undeclared (first use in this function)
mod_uid.c:176: warning: assignment makes pointer from integer without a cast
mod_uid.c:184: warning: assignment makes pointer from integer without a cast
mod_uid.c: In function 'spot_cookie':
mod_uid.c:197: error: 'uid_module' undeclared (first use in this function)
mod_uid.c:203: warning: cast to pointer from integer of different size
...
>How-To-Repeat:
Build the port against apache20/22
>Fix:
--- mod_uid_solution1.diff begins here ---
Index: mod_uid/Makefile
===================================================================
RCS file: /home/pcvs/ports/www/mod_uid/Makefile,v
retrieving revision 1.3
diff -u -r1.3 Makefile
--- mod_uid/Makefile 21 May 2009 20:45:34 -0000 1.3
+++ mod_uid/Makefile 30 Mar 2011 12:08:23 -0000
@@ -23,6 +23,7 @@
MODULENAME= mod_uid
.else
MODULENAME= mod_uid2
+BROKEN= does not build
.endif
AP_FAST_BUILD= yes
--- mod_uid_solution1.diff ends here ---
--- mod_uid_solution1.diff begins here ---
Index: mod_uid/Makefile
===================================================================
RCS file: /home/pcvs/ports/www/mod_uid/Makefile,v
retrieving revision 1.3
diff -u -r1.3 Makefile
--- mod_uid/Makefile 21 May 2009 20:45:34 -0000 1.3
+++ mod_uid/Makefile 30 Mar 2011 12:09:26 -0000
@@ -15,15 +15,11 @@
MAKE_JOBS_SAFE= yes
-USE_APACHE= 1.3+
+USE_APACHE= 1.3
PORTDOCS= README.html
-.if !defined(APACHE_PORT) || ${APACHE_PORT} == "www/apache13"
MODULENAME= mod_uid
-.else
-MODULENAME= mod_uid2
-.endif
AP_FAST_BUILD= yes
AP_GENPLIST= yes
--- mod_uid_solution1.diff ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20110330123141.83EFB1065673>