From owner-cvs-src@FreeBSD.ORG Sun Jul 3 01:04:14 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 934CE16AB25; Sun, 3 Jul 2005 00:57:42 +0000 (GMT) (envelope-from ps@mu.org) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7CB3444421; Sun, 3 Jul 2005 00:39:12 +0000 (GMT) (envelope-from ps@mu.org) Received: by elvis.mu.org (Postfix, from userid 1000) id 749D86D9C9; Sat, 2 Jul 2005 17:37:41 -0700 (PDT) X-Original-To: ps@mu.org Delivered-To: ps@mu.org Received: from mx2.freebsd.org (mx2.freebsd.org [216.136.204.119]) by elvis.mu.org (Postfix) with ESMTP id 1B86D5C9A7 for ; Tue, 18 Jan 2005 00:35:31 -0800 (PST) Received: from hub.freebsd.org (hub.freebsd.org [216.136.204.18]) by mx2.freebsd.org (Postfix) with ESMTP id F355F56493 for ; Tue, 18 Jan 2005 08:35:30 +0000 (GMT) (envelope-from owner-src-committers@FreeBSD.org) Received: by hub.freebsd.org (Postfix) id F35CD16A543; Tue, 18 Jan 2005 08:35:26 +0000 (GMT) Delivered-To: ps@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 538) id 218B116A4D0; Tue, 18 Jan 2005 08:35:10 +0000 (GMT) Delivered-To: src-committers@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DC62C16A4CE for ; Tue, 18 Jan 2005 08:35:08 +0000 (GMT) Received: from relay.pair.com (relay00.pair.com [209.68.1.20]) by mx1.FreeBSD.org (Postfix) with SMTP id DED7A43D5C for ; Tue, 18 Jan 2005 08:35:07 +0000 (GMT) (envelope-from silby@silby.com) Received: (qmail 12422 invoked from network); 18 Jan 2005 08:35:07 -0000 Received: from unknown (HELO localhost) (unknown) by unknown with SMTP; 18 Jan 2005 08:35:07 -0000 X-pair-Authenticated: 209.68.2.70 From: Mike Silbersack To: John Baldwin In-Reply-To: <200501172034.43213.jhb@FreeBSD.org> Message-ID: <20050118023301.C2462@odysseus.silby.com> References: <200501170756.j0H7uSU9031593@repoman.freebsd.org> <200501172034.43213.jhb@FreeBSD.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Sender: owner-src-committers@FreeBSD.org Precedence: bulk X-Loop: FreeBSD.ORG X-Spam-Checker-Version: SpamAssassin 3.0.1 (2004-10-22) on elvis.mu.org X-Spam-Status: No, score=-6.5 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.0.1 X-Spam-Level: Cc: cvs-src@FreeBSD.org, Mike Silbersack , cvs-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: cvs commit: src/sys/kern sys_pipe.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Date: Sun, 03 Jul 2005 01:04:18 -0000 X-Original-Date: Tue, 18 Jan 2005 02:35:05 -0600 (CST) X-List-Received-Date: Sun, 03 Jul 2005 01:04:18 -0000 On Mon, 17 Jan 2005, John Baldwin wrote: > On Monday 17 January 2005 02:56 am, Mike Silbersack wrote: >> Rearrange the kninit calls for both directions of a pipe so that >> they both happen before pipe backing allocation occurs. Previously, >> a pipe memory shortage would cause a panic due to a KNOTE call >> on an uninitialized si_note. >> >> Reported by: Peter Holm >> MFC after: 1 week > > Good catch! > > -- > John Baldwin <>< http://www.FreeBSD.org/~jhb/ I hope you mean good catch on Peter's part, not mine. To create the panic, all I had to to was create a simple program which calls pipe repeatedly; I should have written / committed that program back when I was working on pipes last... I'm going to commit my simple test program when I get a chance, and see if I can write modified versions to test the other allocation failure cases as well. Mike "Silby" Silbersack