From owner-svn-src-all@freebsd.org Sun Feb 3 00:30:40 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 726E014AA09A; Sun, 3 Feb 2019 00:30:40 +0000 (UTC) (envelope-from pkelsey@gmail.com) Received: from mail-pg1-f181.google.com (mail-pg1-f181.google.com [209.85.215.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id ED77670E9E; Sun, 3 Feb 2019 00:30:39 +0000 (UTC) (envelope-from pkelsey@gmail.com) Received: by mail-pg1-f181.google.com with SMTP id v28so4683155pgk.10; Sat, 02 Feb 2019 16:30:39 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=GUEtbJNu4aySLLd+PIoU8DfJ+H9oaSz752YsuaEA/jQ=; b=HfRVzCOeXNzILgxe/owCBkmllZLysg3ktW1IJ9CJIelKpv5nhZF95/yOZRt6wH20wK 8f60J+Ly6ZxGh7s5a6XPJIW2Wy2df+epsxAHc+aGc3UZ8Dz8/502f7bOg1Az0f8EyiSy VdK7lpyonk4Z6aLOyx2KH7zP935bhS8jg2ptrBAHs6x/kNDHYZ7gQb9GeB6WGJe6Oocc YjYd9inaVaVhpeRJZlzsVOg87nXJEllH8cPPB5+SKw8+nFIdlF+6Yrcx7aoRRZ+uYX1/ 3UFNLFwGPFERzLswp36HtWRTm2WXOoCnkD6q9Vr6FEcWnxWnsE+f9GuIi8MElCnwh1Es nIQA== X-Gm-Message-State: AHQUAuaVWlpZU1HuQfWX6dzEzkeemx+g63SxGyN0RdC5Erz9R6F6hpHa DWASN7KZJQHIvJq0gg52M+hG16W5n5yis3BjYf+Tgg== X-Google-Smtp-Source: AHgI3IZNFRT0atHVZv3IeXYJkzApJXaf/RyLseQ2fPfvylmvNF9dY6/HlzXZMuBz4yVLsuKakQCEEmxiSBxY3VSCp6Q= X-Received: by 2002:a63:f74f:: with SMTP id f15mr7868325pgk.190.1549153832537; Sat, 02 Feb 2019 16:30:32 -0800 (PST) MIME-Version: 1.0 References: <201902022114.x12LEsE8058821@repo.freebsd.org> <7D5D3255-CF9C-4F13-A0A9-965AA2E7AE81@gmail.com> In-Reply-To: <7D5D3255-CF9C-4F13-A0A9-965AA2E7AE81@gmail.com> From: Patrick Kelsey Date: Sat, 2 Feb 2019 19:30:18 -0500 Message-ID: Subject: Re: svn commit: r343688 - head/sys/dev/vmware/vmxnet3 To: Enji Cooper Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org X-Rspamd-Queue-Id: ED77670E9E X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.93 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.93)[-0.931,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 03 Feb 2019 00:30:40 -0000 On Sat, Feb 2, 2019 at 7:27 PM Enji Cooper wrote: > Hi Patrick, > > On Feb 2, 2019, at 13:14, Patrick Kelsey wrote: > > Author: pkelsey > Date: Sat Feb 2 21:14:53 2019 > New Revision: 343688 > URL: https://svnweb.freebsd.org/changeset/base/343688 > > Log: > Fix interrupt index configuratoin when using MSI interrupts. > > When in MSI mode, the device was only being configured with one > interrupt index, but it needs two - one for the actual interrupt and > one to park the tx queue at. > > Also clarified comments relating to interrupt index assignment. > > Reported by: Yuri Pankov > MFC after: 1 day > > > Does this change partly fix > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=203874 ? > No, this fixes the behavior of the iflib version of the vmx(4) driver when that bug causes its interrupt configuration code to fall into the MSI path (because MSI-X has been blacklisted). -Patrick