Date: Tue, 13 Dec 2005 05:35:49 GMT From: Jeremy Messenger <mezz@FreeBSD.org> To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/90319: [PATCH], change acroread7 to use tarball rather than rpm. Message-ID: <200512130535.jBD5ZnJk048783@freefall.freebsd.org> Resent-Message-ID: <200512130540.jBD5e3tW048902@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 90319
>Category: ports
>Synopsis: [PATCH], change acroread7 to use tarball rather than rpm.
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Tue Dec 13 05:40:02 GMT 2005
>Closed-Date:
>Last-Modified:
>Originator: Jeremy Messenger
>Release: FreeBSD 6.0-STABLE i386
>Organization:
>Environment:
System: FreeBSD freefall.freebsd.org 6.0-STABLE FreeBSD 6.0-STABLE #0: Sat Dec
10 03:18:20 UTC 2005 kensmith@freefall.freebsd.org:/usr/obj/usr/src/sys/FREEFALL
i386
>Description:
1) ${PREFIX}/lib/acroread/usr/local/Adobe[...] is not right, which
there has double main directory (ie: /usr/local[...]/usr/local) and
is too long. The RPM's original location is /usr/Adobe/Acrobat7.0[...].
The best method is to use the tarball instead RPM that has a
installer.
2) Since, you love to follow the license, so I had to input in here. I
believe that your method of using RPM has violated the license,
because your method is called a new installer by extract from RPM
then install by your Makefile. In the license (LICREAD.TXT) said:
==========================================
2.5 No Modification. You may customize or extend the functionality
of the installer for the Software as specifically allowed by
instructions found at http://www.adobe.com/support/main.html or
http://partners.adobe.com (e.g., installation of additional plug-in
and help files). You may not otherwise alter or modify the Software
or create a new installer for the Software. [...goes on...]
==========================================
japanese/acroread's method is using tarball that doesn't violate the
license by using Adobe's installer without any of modify and use its
functions/options for prefix and etc. I copied from
japanese/acroread/Makefile to acroread7/Makefile with a few modify
such as install in ${PREFIX}/Adobe/Acrobat7.0 and other stuff that
is very close to same default as in the Adobe's installer.
I removed the "Be sure to read the license agreement in" part,
because the installer will required any of you to read the license
and type 'accept' or 'decline' if you agree or not with it before
you install it. Adobe will love us more for this.
3) Change from bin/acroread7 to bin/acroread, because it broke the
plugin and other third-party apps. The print/acroread (version 5)
has been marked as FORBIDDEN and will be remove in Jan.
4) Add symlink of plugin in lib/browser_linux_plugins.
5) I am not going to be surprised if my patch will break other slave
port (adobe language), so I don't mind to modify all of them. I
personal would put CONFLICTS to the each others in those ports. It
makes no sense for us to have two acroread7 installed at the same
time, because of plugins and 'acroread' in the other third-party
apps. If we put CONFLICTS then all other third-party apps will
working with those acroread7 ports without any of modify.
Any thought on this?
6) Using static plist, the dynamic plist is not need to be in this
port.
7) I didn't add BRANDELF or remove the NO_FILTER_SHLIBS, because I am
kind of confused from the Adobe's license. I am leaving that kind of
stuff alone.
If there is any of my English grammar that is confusing you, please feel free
to tell me that you don't understand some parts in here. I will be happy to
try to make a better one.
>How-To-Repeat:
n/a
>Fix:
Patch: http://people.freebsd.org/~mezz/diff/acroread7.diff
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200512130535.jBD5ZnJk048783>