From owner-freebsd-current@FreeBSD.ORG  Fri Oct 25 10:38:50 2013
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTP id 6FEC4EF4;
 Fri, 25 Oct 2013 10:38:50 +0000 (UTC)
 (envelope-from theraven@FreeBSD.org)
Received: from theravensnest.org (theraven.freebsd.your.org [216.14.102.27])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id 3BED42CBE;
 Fri, 25 Oct 2013 10:38:49 +0000 (UTC)
Received: from [10.60.213.211]
 (173-13-112-142-NewEngland.hfc.comcastbusiness.net [173.13.112.142])
 (authenticated bits=0)
 by theravensnest.org (8.14.5/8.14.5) with ESMTP id r9PAcmC8063141
 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO);
 Fri, 25 Oct 2013 10:38:48 GMT (envelope-from theraven@FreeBSD.org)
Content-Type: text/plain; charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 6.5 \(1508\))
Subject: Re: gperf/src/options.cc -- quiesce clang warnings
 -Wlogical-op-parentheses
From: David Chisnall <theraven@FreeBSD.org>
In-Reply-To: <1382665803.2498.13.camel@localhost>
Date: Fri, 25 Oct 2013 06:38:43 -0400
Content-Transfer-Encoding: quoted-printable
Message-Id: <14061B35-A258-4368-BECD-9934CF594AE1@FreeBSD.org>
References: <1382327452.2610.5.camel@localhost>
 <1382399026.7749.3.camel@localhost>
 <0744E30D-89EF-4340-A7DC-968AC27F302B@FreeBSD.org>
 <1382663626.2498.4.camel@localhost>
 <3656E3A3-F76E-42F4-BCFC-8B0F49FF5DA9@FreeBSD.org>
 <1382665803.2498.13.camel@localhost>
To: sbruno@FreeBSD.org
X-Mailer: Apple Mail (2.1508)
Cc: Matthew Fleming <mdf@FreeBSD.org>,
 "freebsd-current@freebsd.org" <freebsd-current@FreeBSD.org>
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
 <freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-current>, 
 <mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
 <mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 25 Oct 2013 10:38:50 -0000

On 24 Oct 2013, at 21:50, Sean Bruno <sean_bruno@yahoo.com> wrote:

> On Thu, 2013-10-24 at 21:24 -0400, David Chisnall wrote:
>>=20
>> Don't forget the freelocale() at the end.
>>=20
> ah, ok.  I wish that there was some kind of example that I could go =
off
> of in the man page.  I'm sort of trundling my way through various bits
> of the system to find the obvious example of how to do this correctly.
>=20
>> This seems like a very slow way of doing what was very fast in the
>> original code though.  I'm not entirely sure what you're aiming to
>> gain in this refactoring.
>>=20
>> David
>>=20
>>=20
>=20
> I'm simply trying to address the warnings that appear due to clang.  I
> find the builds very noisy and if there's a better way to address this
> issue, I'm totally open to suggestions.

Well, for contrib code that isn't going to be around for much longer =
like gperf, the best thing to do is probably just stick =
-Wno-logical-op-parentheses in the CFLAGS.  Alternatively, adding the =
brackets as it suggested to indicate precedence is simple.

David