From owner-cvs-all Thu Jul 19 7:49:51 2001 Delivered-To: cvs-all@freebsd.org Received: from bazooka.unixfreak.org (bazooka.unixfreak.org [63.198.170.138]) by hub.freebsd.org (Postfix) with ESMTP id 5078237B401; Thu, 19 Jul 2001 07:49:45 -0700 (PDT) (envelope-from dima@unixfreak.org) Received: from hornet.unixfreak.org (hornet [63.198.170.140]) by bazooka.unixfreak.org (Postfix) with ESMTP id 0B1AA3E2F; Thu, 19 Jul 2001 07:49:45 -0700 (PDT) To: Mikhail Teterin Cc: kris@FreeBSD.org, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.sbin/mailwrapper mailwrapper.c In-Reply-To: <200107191440.f6JEedO32662@aldan.algebra.com>; from mi@aldan.algebra.com on "Thu, 19 Jul 2001 10:40:36 -0400 (EDT)" Date: Thu, 19 Jul 2001 07:49:45 -0700 From: Dima Dorfman Message-Id: <20010719144945.0B1AA3E2F@bazooka.unixfreak.org> Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Mikhail Teterin writes: > On 18 Jul, Kris Kennaway wrote: > > kris 2001/07/18 22:04:46 PDT > > > > Modified files: (Branch: RELENG_4) > > usr.sbin/mailwrapper mailwrapper.c > > Log: > > MFC: r1.6: You can't free a string and then use it as the error > > message to errx. Instead use warn to print the string, then cleanup > > and exit normally. > > This is not the first place to have this issue (I remember a similar > commit from the past). May be, it is time to add another err* function, > which will free the passed error message prior to exiting? > > It was not there before, I guess, because the "founding fathers" did not > concern themselves with the fate of the allocated memory after exit :-) Maybe I'm missing something, but who cares about allocated memory *after* *exit*? To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message